From: Andy Shevchenko <andy@kernel.org>
To: Boerge Struempfel <boerge.struempfel@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andrew Jeffery <andrew@aj.id.au>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Rob Herring <robh@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
bstruempfel@ultratronik.de
Subject: Re: [PATCH v3] gpiolib: sysfs: Fix error handling on failed export
Date: Wed, 29 Nov 2023 18:10:19 +0200 [thread overview]
Message-ID: <ZWdia1rDg9pH2Fhu@smile.fi.intel.com> (raw)
In-Reply-To: <20231129152307.28517-1-boerge.struempfel@gmail.com>
On Wed, Nov 29, 2023 at 04:23:07PM +0100, Boerge Struempfel wrote:
> If gpio_set_transitory() fails, we should free the GPIO again. Most
> notably, the flag FLAG_REQUESTED has previously been set in
> gpiod_request_commit(), and should be reset on failure.
>
> To my knowledge, this does not affect any current users, since the
> gpio_set_transitory() mainly returns 0 and -ENOTSUPP, which is converted
> to 0. However the gpio_set_transitory() function calles the .set_config()
> function of the corresponding GPIO chip and there are some GPIO drivers in
> which some (unlikely) branches return other values like -EPROBE_DEFER,
> and -EINVAL. In these cases, the above mentioned FLAG_REQUESTED would not
> be reset, which results in the pin being blocked until the next reboot.
Thank you!
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-29 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 15:23 Boerge Struempfel
2023-11-29 16:10 ` Andy Shevchenko [this message]
2023-12-01 9:45 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWdia1rDg9pH2Fhu@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrew@aj.id.au \
--cc=boerge.struempfel@gmail.com \
--cc=brgl@bgdev.pl \
--cc=bstruempfel@ultratronik.de \
--cc=ckeepax@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®