From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91BCC4167B for ; Thu, 30 Nov 2023 16:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345410AbjK3Qhn (ORCPT ); Thu, 30 Nov 2023 11:37:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbjK3Qhm (ORCPT ); Thu, 30 Nov 2023 11:37:42 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C47B8D48; Thu, 30 Nov 2023 08:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701362268; x=1732898268; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6w9HL+61RiI8S7i1ovgXfTxFrhwEVviMStPuLeP1uz0=; b=fmZtFfXR03U+GQpx6+Qtlj+z/mBP0yQRNLeT/nWqbrNvxDnAUQvHi/uX dapzByEdIDobRd0j1kkgRKmG7N6vkZsukjwdDTKNZhrGoEWWQsI7JBK49 iWQOeFN484EFg7jGuOV3hZp5Ed4oWjSqGfiy5IWT4DCbOtdAP7IC5sRLw F13hQj4qJyhiyy8wEUqwkmeY5U0BefGf/p1uN3wGO4liymi2evPqaSPiy yAFYNzKJZNWNHulqJjdKpGstIjnZM8kZ6Yv5dsQVbolZ/2grafItfTAeq v66bIcMGsC6/TZexBOCTSyjqZFilTvQObPrdBFSpiQ3zc7ynvOcElihFI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="373537486" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="373537486" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 08:37:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="892863328" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="892863328" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 08:37:46 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r8k2p-00000000kOx-3DRc; Thu, 30 Nov 2023 18:37:43 +0200 Date: Thu, 30 Nov 2023 18:37:43 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 08/10] pinctrl: sppctl: use gpiochip_dup_line_label() Message-ID: References: <20231130134630.18198-1-brgl@bgdev.pl> <20231130134630.18198-9-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130134630.18198-9-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2023 at 02:46:28PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the new gpiochip_dup_line_label() helper to safely retrieve the > descriptor label. ... > for (i = 0; i < chip->ngpio; i++) { > - label = gpiochip_is_requested(chip, i); > - if (!label) > - label = ""; > + char *label __free(kfree) = gpiochip_dup_line_label(chip, i); > + if (IS_ERR(label)) > + continue; > > seq_printf(s, " gpio-%03d (%-16.16s | %-16.16s)", i + chip->base, > - chip->names[i], label); > + chip->names[i], label ?: ""); So, as it's non-ABI change, we still can use "reserved" word here as well ("Unrequested" or whatever.) -- With Best Regards, Andy Shevchenko