From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 75323C4167B
	for <linux-kernel@archiver.kernel.org>; Thu, 30 Nov 2023 22:28:20 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1377150AbjK3W2M (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 30 Nov 2023 17:28:12 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40764 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230203AbjK3W2L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2023 17:28:11 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF45610E5
        for <linux-kernel@vger.kernel.org>; Thu, 30 Nov 2023 14:28:17 -0800 (PST)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1186CC433C9;
        Thu, 30 Nov 2023 22:28:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1701383297;
        bh=pCd4lFCDaZ7PiW4wTVqQ114lN6MT9ckyByeLpH+GFAw=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=AS7PKpoxuGooLU3MtdgH2+Ev7ToehwgZt0qBOOQByGtOGBmJFJ++fB7vmlRlERSiz
         fKZdJsJhS7WefOPmAljGpHWBQPlS3ErIcfVOtscafQa77EAtcURW2/B6DKTstKDT6i
         BKWnFfcIhIA1VZRMqGntHFSfbFziQa7yhV0CtYUIMa92dz38S4lyfzNXLIEtdEY/Os
         tOTKwCQOuAnJn+fbRlUkc9a5SbrSOC2C5uKZxGg79hId7MwTptzEktgsBqDSNA9M8e
         PZ1GNEQZzyzoPtLnxkkr4oitCvy66rCfF9MHZ0fzZpJF0PkQYprC0jknftxR3YXA0K
         RONGnOK6Dq81g==
Date:   Thu, 30 Nov 2023 15:28:14 -0700
From:   Keith Busch <kbusch@kernel.org>
To:     Bitao Hu <yaoma@linux.alibaba.com>
Cc:     sagi@grimberg.me, axboe@kernel.dk, hch@lst.de,
        kanie@linux.alibaba.com, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: fix deadlock between reset and scan
Message-ID: <ZWkMfqF_VociudNB@kbusch-mbp.dhcp.thefacebook.com>
References: <c47a0edd-7437-4c21-b7cf-f969ff85bf78@grimberg.me>
 <1701310417-301-1-git-send-email-yaoma@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1701310417-301-1-git-send-email-yaoma@linux.alibaba.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 30, 2023 at 10:13:37AM +0800, Bitao Hu wrote:
> Fix by marking the ctrl with say NVME_CTRL_FROZEN flag set in
> nvme_start_freeze and cleared in nvme_unfreeze. Then the scan can check
> it before adding the new namespace (under the namespaces_rwsem).

Thanks for the detailed explanation. This looks good to me.

Reviewed-by: Keith Busch <kbsuch@kernel.org>