From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3475AC07E97 for ; Fri, 1 Dec 2023 10:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378292AbjLAKgq (ORCPT ); Fri, 1 Dec 2023 05:36:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378239AbjLAKgl (ORCPT ); Fri, 1 Dec 2023 05:36:41 -0500 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A689F4; Fri, 1 Dec 2023 02:36:48 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 5FB93206C0; Fri, 1 Dec 2023 11:36:46 +0100 (CET) Date: Fri, 1 Dec 2023 11:36:44 +0100 From: Francesco Dolcini To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH v7 07/12] wifi: mwifiex: fixed TLV error for station add cmd. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-8-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128083115.613235-8-yu-hao.lin@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 04:31:10PM +0800, David Lin wrote: > TLV commands setting for host command HostCmd_CMD_ADD_NEW_STATION is > not correct. This issue will set wrong station information to firmware. > > Without this patch, transmission will get 50-70% low throughput for host > mlme AP mode. Is this an issue affecting also the existing code, or it depends on the host MLE one? >From the commit message to me it looks like it should be a dedicated and separated patch, therefore should probably be before the other patch (or maybe even a separated one, maybe is easier to get it done this way?) Francesco