From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29736C4167B for ; Fri, 1 Dec 2023 10:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378312AbjLAKiz (ORCPT ); Fri, 1 Dec 2023 05:38:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378266AbjLAKiy (ORCPT ); Fri, 1 Dec 2023 05:38:54 -0500 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8121AF4; Fri, 1 Dec 2023 02:39:01 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id CC4D720645; Fri, 1 Dec 2023 11:38:59 +0100 (CET) Date: Fri, 1 Dec 2023 11:38:58 +0100 From: Francesco Dolcini To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH v7 09/12] wifi: mwifiex: fixed the way to handle link lost. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-10-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128083115.613235-10-yu-hao.lin@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 04:31:12PM +0800, David Lin wrote: > If host mlme is enabled, event EVENT_LINK_LOST must be handled with > sending deauthentication to upper layers. > > Without this patch, if AP is leaving and station won't receive > deauthentication from AP, station won't reconnect to AP again. As commented on previous patches this should be done in the commit that introduce the host mlme feature in the first place. No fixup for a non committed patch, you should just avoid introducing the bug in the first place. Francesco