From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5A5C4167B for ; Fri, 1 Dec 2023 10:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378315AbjLAKkR (ORCPT ); Fri, 1 Dec 2023 05:40:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378239AbjLAKkQ (ORCPT ); Fri, 1 Dec 2023 05:40:16 -0500 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24B6196; Fri, 1 Dec 2023 02:40:22 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 1B27220645; Fri, 1 Dec 2023 11:40:21 +0100 (CET) Date: Fri, 1 Dec 2023 11:40:19 +0100 From: Francesco Dolcini To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-12-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128083115.613235-12-yu-hao.lin@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 04:31:14PM +0800, David Lin wrote: > 1. Moved struct mwifiex_ieee80211_mgmt from cfg80211.c to fw.h. > 2. Defined WLAN_AUTH_NONE instead of using 0xFFFF directly. > 3. Changed host_mlme of struct mwifiex_adapter to host_mlme_enabled. > 4. Moved mwifiex_check_key_api_ver() to end of mwifiex_ret_get_hw_spec(). > 5. Redefined MWIFIEX_MGMT_HEADER_LEN and MWIFIEX_AUTH_BODY_LEN. You should fix the existing patch, not create a fixup commit on top. Francesco