From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9D0C4167B for ; Fri, 1 Dec 2023 10:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378219AbjLAKPc (ORCPT ); Fri, 1 Dec 2023 05:15:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378203AbjLAKPa (ORCPT ); Fri, 1 Dec 2023 05:15:30 -0500 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE64884; Fri, 1 Dec 2023 02:15:35 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 732F220645; Fri, 1 Dec 2023 11:15:33 +0100 (CET) Date: Fri, 1 Dec 2023 11:15:31 +0100 From: Francesco Dolcini To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-3-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128083115.613235-3-yu-hao.lin@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 04:31:05PM +0800, David Lin wrote: > If host mlme is enabled, gropu rekey offload should be disabled. > > Signed-off-by: David Lin > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 +++ > drivers/net/wireless/marvell/mwifiex/main.c | 4 ++++ > drivers/net/wireless/marvell/mwifiex/util.c | 7 +++++++ > 3 files changed, 14 insertions(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index 40c39e4765f7..3d59e6a441b9 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -3657,6 +3657,9 @@ static int mwifiex_set_rekey_data(struct wiphy *wiphy, struct net_device *dev, > if (!ISSUPP_FIRMWARE_SUPPLICANT(priv->adapter->fw_cap_info)) > return -EOPNOTSUPP; > > + if (priv->adapter->host_mlme) > + return 0; this is a fixup of the previous patch, you should not introduce an issue and fix it in the following patch. Please make it correct in the first place fixing up that patch. > + > return mwifiex_send_cmd(priv, HostCmd_CMD_GTK_REKEY_OFFLOAD_CFG, > HostCmd_ACT_GEN_SET, 0, data, true); > } > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c > index d99127dc466e..3bebb6c37604 100644 > --- a/drivers/net/wireless/marvell/mwifiex/main.c > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > @@ -802,6 +802,10 @@ mwifiex_bypass_tx_queue(struct mwifiex_private *priv, > "bypass txqueue; eth type %#x, mgmt %d\n", > ntohs(eth_hdr->h_proto), > mwifiex_is_skb_mgmt_frame(skb)); > + if (ntohs(eth_hdr->h_proto) == ETH_P_PAE) > + mwifiex_dbg(priv->adapter, MSG, > + "key: send EAPOL to %pM\n", > + eth_hdr->h_dest); this is just debug code, at a first glance not sure i > diff --git a/drivers/net/wireless/marvell/mwifiex/util.c b/drivers/net/wireless/marvell/mwifiex/util.c > index 23675c1cecae..ff1b2f162c30 100644 > --- a/drivers/net/wireless/marvell/mwifiex/util.c > +++ b/drivers/net/wireless/marvell/mwifiex/util.c > @@ -482,8 +482,15 @@ mwifiex_process_mgmt_packet(struct mwifiex_private *priv, > return 0; > > if (ieee80211_is_deauth(ieee_hdr->frame_control)) { > + mwifiex_dbg(priv->adapter, MSG, > + "auth: receive deauth from %pM\n", > + ieee_hdr->addr3); ditto > priv->auth_flag = 0; > priv->auth_alg = 0xFFFF; > + } else { > + mwifiex_dbg(priv->adapter, MSG, > + "assoc: receive disasso from %pM\n", > + ieee_hdr->addr3); ditto