From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0383AC4167B for ; Fri, 1 Dec 2023 15:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjLAPs3 (ORCPT ); Fri, 1 Dec 2023 10:48:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjLAPs1 (ORCPT ); Fri, 1 Dec 2023 10:48:27 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63355F3; Fri, 1 Dec 2023 07:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701445714; x=1732981714; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S1Dd8iISz5gAjTwi1OBZoZTrthWL/j69ur54GuLmsic=; b=kyT1GHMBe/n4qvhwJtshUbrgGU3WxrNNbWzBsztO5qd/5K7P2L3f82v5 y7b0NbZFgUHE4gukuO6EGzR2Q/xlcjJ+Mrz+WvOByX9egAEEjsyoHsz28 otINppgYH5osZPwCDXSQ8/+Y0v72HVIr2289NGyvvSPxT/kUR5Rm/OpQ8 UUW0H0E6fFpKQKZQz9MdD4wUnB9HNXMHlVoQUyg7Q37VUYb9soCDlZQGv anEdzLRRKG4pG8GbzF4lc++MZB9/hHv0LN6Kk5Sp6aOu6y3hu1Mtg79uc bC822ikgqseAEXiuZ2b3JcBs2rWUUKaHlGuGdtxLacPg6GcIvec4T6V8a w==; X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="392376910" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="392376910" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 07:48:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="887693817" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="887693817" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 07:48:32 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r95kk-000000011m6-1Lyg; Fri, 01 Dec 2023 17:48:30 +0200 Date: Fri, 1 Dec 2023 17:48:30 +0200 From: Andy Shevchenko To: Christophe JAILLET Cc: Sudip Mukherjee , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] parport: Save a few bytes of memory Message-ID: References: <0eba5f2ddd142ab0f577f67e482d1152b40ee720.1700860416.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eba5f2ddd142ab0f577f67e482d1152b40ee720.1700860416.git.christophe.jaillet@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2023 at 10:14:36PM +0100, Christophe JAILLET wrote: > Most of parport_register_dev_model() callers pass a 'name' that is a > constant string. > > So kstrdup_const() can be used to save the duplication of this string > when it is not needed. This saves a few bytes of memory. > > Use kfree_const() accordingly when this string is freed. Looks good to have, hence no objection from me, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko