From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3F1C4167B for ; Wed, 6 Dec 2023 05:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376735AbjLFFoM (ORCPT ); Wed, 6 Dec 2023 00:44:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376643AbjLFFoI (ORCPT ); Wed, 6 Dec 2023 00:44:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DEC018F; Tue, 5 Dec 2023 21:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X+sjnLZJ2l3e2jdAF84glp/xQ6OVtmNr71eC56Hfvi0=; b=AaHiFtxwniAaOcJjCOrvNRytvi N0klteAyDmK89PqenX1ZmD/oxc+wJzYNX95a42dOBEeftTmJnVVHgEfPx8nvW/5a3q3Ul1dc52oKz Q+ZaucPg2jyjMppZ/T9PqxC+vTv04K+nKosBNYTIVX/4v/jkcuwAQbnmt+HLl05hocrwTss3AU64r 9ryVKSAVXot1wj/C2jxUkhJJQEd38mayys4TkVPFvOEH9S1HXPIXCv3Q0+7waLjQJDIZR1U21sRZa 2diq2SQYO+pXfg442jiEYy7HyKwgidTu97iJPS1mj31GmMkUzOLAXGOvErFv2D9/0yxlw55sKdM24 NOLBpJcg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAkhX-0097d5-2Z; Wed, 06 Dec 2023 05:44:03 +0000 Date: Tue, 5 Dec 2023 21:44:03 -0800 From: Christoph Hellwig To: Christian Brauner Cc: Jens Axboe , NeilBrown , Al Viro , Oleg Nesterov , Chuck Lever , Jeff Layton , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] Allow a kthread to declare that it calls task_work_run() Message-ID: References: <20231204014042.6754-1-neilb@suse.de> <20231204014042.6754-2-neilb@suse.de> <170172377302.7109.11739406555273171485@noble.neil.brown.name> <20231205-altbacken-umbesetzen-e5c0c021ab98@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205-altbacken-umbesetzen-e5c0c021ab98@brauner> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2023 at 12:14:29PM +0100, Christian Brauner wrote: > > For me, the more core of an export it is, the stronger the reason it > > should be GPL. FWIW, I don't think exporting task_work functionality is > > a good idea in the first place, but if there's a strong reason to do so, > > Yeah, I'm not too fond of that part as well. I don't think we want to > give modules the ability to mess with task work. This is just asking for > trouble. It just seems like a really bad idea. At the same time it fixes a real problem. If we go a step back how could we fix it in a better way? Do we even need the task_run based delay for file usage from kernel threads?