From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 670DBC4167B
	for <linux-kernel@archiver.kernel.org>; Fri,  8 Dec 2023 02:44:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1573004AbjLHCof (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 7 Dec 2023 21:44:35 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42192 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229531AbjLHCoe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2023 21:44:34 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3CDF1708
        for <linux-kernel@vger.kernel.org>; Thu,  7 Dec 2023 18:44:40 -0800 (PST)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFA2FC433C7;
        Fri,  8 Dec 2023 02:44:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1702003480;
        bh=wuEMZ81uJKarUyz9kBDH4zgx1rrGtZ2JyolpU+3aRiM=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=pL7RE0MChzRmd5+zFgBRqP2gm0x35pQjDnQ/pvXGYQbkFekqXMJF4XBtatGzh6Mw3
         DXX1DS3AJ1wUYSsDsQEH62rAJMpMU0OiePmTuAdnJwmQNQxhRgr/tZ9xdhhRmYz/ic
         JkDlnfgOfacefgnnOF6C1/t5Yr+9FxoT3VT4frjyUuEvXfA2e+ouWVcilcMHNJ5jaW
         554KkpfVUeFErCu85NQXOzaOYPFBXQYu81R3KA4uS9tYeLmafcTQkcWfub+dyP5hi1
         PXTWMyXcKOREPs6aFr+QSRcVwE18aQho0GDSUOvDNhUipxsYBz+u4OIOR/V+c9jeiV
         jiV1SVn7fO1Qg==
Date:   Thu, 7 Dec 2023 19:44:37 -0700
From:   Keith Busch <kbusch@kernel.org>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Li Feng <fengli@smartx.com>, Jens Axboe <axboe@kernel.dk>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:VIRTIO BLOCK AND SCSI DRIVERS" 
        <virtualization@lists.linux.dev>
Subject: Re: [PATCH] virtio_blk: set the default scheduler to none
Message-ID: <ZXKDFdzXN4xQAuBm@kbusch-mbp>
References: <20231207043118.118158-1-fengli@smartx.com>
 <ZXJ4xNawrSRem2qe@fedora>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZXJ4xNawrSRem2qe@fedora>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 08, 2023 at 10:00:36AM +0800, Ming Lei wrote:
> On Thu, Dec 07, 2023 at 12:31:05PM +0800, Li Feng wrote:
> > virtio-blk is generally used in cloud computing scenarios, where the
> > performance of virtual disks is very important. The mq-deadline scheduler
> > has a big performance drop compared to none with single queue. In my tests,
> > mq-deadline 4k readread iops were 270k compared to 450k for none. So here
> > the default scheduler of virtio-blk is set to "none".
> 
> The test result shows you may not test HDD. backing of virtio-blk.
> 
> none can lose IO merge capability more or less, so probably sequential IO perf
> drops in case of HDD backing.

More of a curiosity, as I don't immediately even have an HDD to test
with! Isn't it more useful for the host providing the backing HDD use an
appropriate IO scheduler? virtio-blk has similiarities with a stacking
block driver, and we usually don't need to stack IO schedulers.