From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6809CC10DC1 for ; Fri, 8 Dec 2023 03:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573063AbjLHD2N (ORCPT ); Thu, 7 Dec 2023 22:28:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbjLHD2M (ORCPT ); Thu, 7 Dec 2023 22:28:12 -0500 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEAC7D53; Thu, 7 Dec 2023 19:28:17 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rBRX6-008IE0-47; Fri, 08 Dec 2023 11:28:09 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 08 Dec 2023 11:28:17 +0800 Date: Fri, 8 Dec 2023 11:28:17 +0800 From: Herbert Xu To: "Gonglei (Arei)" Cc: "linux-crypto@vger.kernel.org" , "Michael S. Tsirkin" , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , wangyangxin , Halil Pasic Subject: Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2023 at 11:52:51AM +0000, Gonglei (Arei) wrote: > Doing ipsec produces a spinlock recursion warning. > This is due to crypto_finalize_request() being called in the upper half. > Move virtual data queue processing of virtio-crypto driver to tasklet. > > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > Reported-by: Halil Pasic > Signed-off-by: wangyangxin > Signed-off-by: Gonglei > --- > v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST. > > drivers/crypto/virtio/virtio_crypto_common.h | 2 ++ > drivers/crypto/virtio/virtio_crypto_core.c | 26 ++++++++++++++++---------- > 2 files changed, 18 insertions(+), 10 deletions(-) Your patch has already been merged. So please send this as an incremental patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt