From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A27C4167B for ; Fri, 8 Dec 2023 13:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573836AbjLHNQp (ORCPT ); Fri, 8 Dec 2023 08:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573820AbjLHNQk (ORCPT ); Fri, 8 Dec 2023 08:16:40 -0500 Received: from mail.avm.de (mail.avm.de [212.42.244.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 980C61724 for ; Fri, 8 Dec 2023 05:16:43 -0800 (PST) Received: from mail-auth.avm.de (dovecot-mx-01.avm.de [212.42.244.71]) by mail.avm.de (Postfix) with ESMTPS; Fri, 8 Dec 2023 14:16:40 +0100 (CET) Received: from buildd.core.avm.de (buildd-sv-01.avm.de [172.16.0.225]) by mail-auth.avm.de (Postfix) with ESMTPA id 9119C806BE; Fri, 8 Dec 2023 14:16:40 +0100 (CET) Received: by buildd.core.avm.de (Postfix, from userid 1000) id 81758180D88; Fri, 8 Dec 2023 14:16:40 +0100 (CET) Date: Fri, 8 Dec 2023 14:16:40 +0100 From: Nicolas Schier To: Leonardo Bras Cc: Masahiro Yamada , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Mauro Carvalho Chehab , Leonardo Bras , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [RESEND RFC PATCH v4 1/1] scripts: Introduce a default git.orderFile Message-ID: Mail-Followup-To: Leonardo Bras , Masahiro Yamada , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Mauro Carvalho Chehab , Leonardo Bras , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org References: <20231205182853.40627-1-leobras.c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231205182853.40627-1-leobras.c@gmail.com> X-purgate-ID: 149429::1702041400-BD6E3A59-C7872309/0/0 X-purgate-type: clean X-purgate-size: 2482 X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2023 at 03:28:51PM -0300, Leonardo Bras wrote: > From: Leonardo Bras > > When reviewing patches, it looks much nicer to have some changes shown > before others, which allow better understanding of the patch before the > the .c files reviewing. > > Introduce a default git.orderFile, in order to help developers getting the > best ordering easier. > > Signed-off-by: Leonardo Bras > Acked-by: Randy Dunlap > --- > > Please provide feedback on what else to add / remove / reorder here! > > Changes since RFCv3: > - Added "*types.h" matching so type headers appear before regular headers > - Removed line ends ($) in patterns: they previously provided a > false-positive > - Fixed build patterns to allow matching Kconfig, Kbuild & Makefile > in any subdirectory > > Changes since RFCv2: > - Fixed licence comment to from /**/ to # > - Fixed filename in how-to comment > - Fix build order: Kconfig -> Kbuild -> Makefile > - Add *.mk extension > - Add line-ends ($) to make sure and get the correct extensions > - Thanks Masahiro Yamada for above suggestions! > - 1 Ack, thanks Randy! > > Changes since RFCv1: > - Added Kconfig* (thanks Randy Dunlap!) > - Changed Kbuild to Kbuild* (improve matching) > > > scripts/git.orderFile | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 scripts/git.orderFile > > diff --git a/scripts/git.orderFile b/scripts/git.orderFile > new file mode 100644 > index 000000000000..7cef02cbba3c > --- /dev/null > +++ b/scripts/git.orderFile > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +# order file for git, to produce patches which are easier to review > +# by diffing the important stuff like header changes first. > +# > +# one-off usage: > +# git diff -O scripts/git.orderFile ... > +# > +# add to git config: > +# git config diff.orderFile scripts/git.orderFile > +# > + > +MAINTAINERS > + > +# Documentation > +Documentation/* > +*.rst > + > +# build system > +*Kconfig* > +*Kbuild* > +*Makefile* > +*.mak > +*.mk I'd like to see 'scripts/*' here, too, to have the build system stuff together. Possibly it makes sense to add .gitignore files here too. Kind regards, Nicolas > + > +# semantic patches > +*.cocci > + > +# headers > +*types.h > +*.h > + > +# code > +*.c > -- > 2.42.0 >