From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B94C4167B for ; Mon, 11 Dec 2023 10:27:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234202AbjLKK1d (ORCPT ); Mon, 11 Dec 2023 05:27:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234465AbjLKK1Q (ORCPT ); Mon, 11 Dec 2023 05:27:16 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF13C1729 for ; Mon, 11 Dec 2023 02:27:18 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B80A52F4 for ; Mon, 11 Dec 2023 02:28:04 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1065F3F738 for ; Mon, 11 Dec 2023 02:27:17 -0800 (PST) Date: Mon, 11 Dec 2023 10:27:06 +0000 From: Liviu Dudau To: Krzysztof Kozlowski Cc: Sudeep Holla , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: juno: align thermal zone names with bindings Message-ID: References: <20231209171612.250868-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231209171612.250868-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 09, 2023 at 06:16:12PM +0100, Krzysztof Kozlowski wrote: > Thermal bindings require thermal zone node names to match > certain patterns: > > juno.dtb: thermal-zones: 'big-cluster', 'gpu0', 'gpu1', 'little-cluster', 'pmic', 'soc' > do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Acked-by: Liviu Dudau Thanks for fixing this! Best regards, Liviu > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 12 ++++++------ > arch/arm64/boot/dts/arm/juno-scmi.dtsi | 12 ++++++------ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 8b4d280b1e7e..b897f5542c0a 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -747,7 +747,7 @@ scpi_sensors0: sensors { > }; > > thermal-zones { > - pmic { > + pmic-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 0>; > @@ -760,7 +760,7 @@ pmic_crit0: trip0 { > }; > }; > > - soc { > + soc-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 3>; > @@ -773,28 +773,28 @@ soc_crit0: trip0 { > }; > }; > > - big_cluster_thermal_zone: big-cluster { > + big_cluster_thermal_zone: big-cluster-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 21>; > status = "disabled"; > }; > > - little_cluster_thermal_zone: little-cluster { > + little_cluster_thermal_zone: little-cluster-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 22>; > status = "disabled"; > }; > > - gpu0_thermal_zone: gpu0 { > + gpu0_thermal_zone: gpu0-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 23>; > status = "disabled"; > }; > > - gpu1_thermal_zone: gpu1 { > + gpu1_thermal_zone: gpu1-thermal { > polling-delay = <1000>; > polling-delay-passive = <100>; > thermal-sensors = <&scpi_sensors0 24>; > diff --git a/arch/arm64/boot/dts/arm/juno-scmi.dtsi b/arch/arm64/boot/dts/arm/juno-scmi.dtsi > index ec85cd2c733c..31929e2377d8 100644 > --- a/arch/arm64/boot/dts/arm/juno-scmi.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-scmi.dtsi > @@ -76,27 +76,27 @@ scmi_sensors0: protocol@15 { > }; > > thermal-zones { > - pmic { > + pmic-thermal { > thermal-sensors = <&scmi_sensors0 0>; > }; > > - soc { > + soc-thermal { > thermal-sensors = <&scmi_sensors0 3>; > }; > > - big-cluster { > + big-cluster-thermal { > thermal-sensors = <&scmi_sensors0 21>; > }; > > - little-cluster { > + little-cluster-thermal { > thermal-sensors = <&scmi_sensors0 22>; > }; > > - gpu0 { > + gpu0-thermal { > thermal-sensors = <&scmi_sensors0 23>; > }; > > - gpu1 { > + gpu1-thermal { > thermal-sensors = <&scmi_sensors0 24>; > }; > }; > -- > 2.34.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯