From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93783C4332F for ; Tue, 12 Dec 2023 11:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346291AbjLLLr6 (ORCPT ); Tue, 12 Dec 2023 06:47:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbjLLLrz (ORCPT ); Tue, 12 Dec 2023 06:47:55 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32F4D9; Tue, 12 Dec 2023 03:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702381682; x=1733917682; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C88BH7kQ+Tml6p1PsEMogJ/FdONSdDo+cGr0kn35/6I=; b=Vs6qoRqsqx2OhVfUE+5KsGTRZLS9oCPIurfh0WGA58lWbzQhVC9SQeKL YIfBH7968IQOi8Ocs3xU90Tj0EPcDh0GrVsaIJVA8ohopj9yzBey7Sw30 Mb7mTUEKpoYH55k7hQ9SnVmhedlPEBpy4lh0wcsGzXQyXeYBl1RHMrLtm 07g1COQxi54wX85S9m+5a1lB48K+xUFtHxfXXwIP9osSmC1Y0PaL0IqCq jPdt5gkxsyDIjy0tjoGiLxW4FMPHqq1SppQarAwpTlskfwdK2IzsXDyvt mlLKgR7HwKYPfv9KCU9QpF4NefRMzfNV1TLY+nUpCDC6blWSo9SCzgOmz g==; X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="1633771" X-IronPort-AV: E=Sophos;i="6.04,270,1695711600"; d="scan'208";a="1633771" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 03:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="896893666" X-IronPort-AV: E=Sophos;i="6.04,270,1695711600"; d="scan'208";a="896893666" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 03:47:55 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id E4E4311F7E4; Tue, 12 Dec 2023 13:47:52 +0200 (EET) Date: Tue, 12 Dec 2023 11:47:52 +0000 From: Sakari Ailus To: Tommaso Merciai Cc: laurent.pinchart@ideasonboard.com, martin.hecht@avnet.eu, michael.roeder@avnet.eu, linuxfancy@googlegroups.com, mhecht73@gmail.com, christophe.jaillet@wanadoo.fr, Mauro Carvalho Chehab , Liam Girdwood , Mark Brown , Hans de Goede , Hans Verkuil , Tomi Valkeinen , Alain Volmat , Paul Elder , Gerald Loacker , Andy Shevchenko , Daniel Scally , Nicholas Roth , Linus Walleij , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v15 3/3] media: i2c: Add support for alvium camera Message-ID: References: <20231204094719.190334-1-tomm.merciai@gmail.com> <20231204094719.190334-4-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tommaso, On Tue, Dec 12, 2023 at 12:44:46PM +0100, Tommaso Merciai wrote: > Hi Sakari, > > On Tue, Dec 12, 2023 at 11:38:42AM +0000, Sakari Ailus wrote: > > Hi Tommaso, > > > > On Mon, Dec 04, 2023 at 10:47:16AM +0100, Tommaso Merciai wrote: > > > The Alvium camera is shipped with sensor + isp in the same housing. > > > The camera can be equipped with one out of various sensor and abstract > > > the user from this. Camera is connected via MIPI CSI-2. > > > > > > Most of the camera module features are supported, with the main exception > > > being fw update. > > > > > > The driver provides all mandatory, optional and recommended V4L2 controls > > > for maximum compatibility with libcamera > > > > > > References: > > > - https://www.alliedvision.com/en/products/embedded-vision-solutions > > > > > > Signed-off-by: Tommaso Merciai > > > > Could you run > > > > ./scripts/checkpatch.pl --strict --max-line-length=80 > > > > and address the issues in a patch on top of this set? > > > > Yes ofc. > You need also the following? > > --- a/drivers/media/i2c/alvium-csi2.c > +++ b/drivers/media/i2c/alvium-csi2.c > @@ -2426,8 +2426,8 @@ static int alvium_probe(struct i2c_client *client) > goto err_powerdown; > > if (!alvium_is_alive(alvium)) { > - dev_err_probe(dev, ret, "Device detection failed\n"); > ret = -ENODEV; > + dev_err_probe(dev, ret, "Device detection failed\n"); > goto err_powerdown; > } > > Let me know. Thanks for your work. Thank you, but I've already addressed that in my tree. -- Sakari Ailus