From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA29C4332F for ; Wed, 13 Dec 2023 07:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378779AbjLMHvc (ORCPT ); Wed, 13 Dec 2023 02:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378554AbjLMHva (ORCPT ); Wed, 13 Dec 2023 02:51:30 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68C84BD; Tue, 12 Dec 2023 23:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=yTukDIvPvseoy1hNbDDGgwwb3/RxkKSXoPYCWaH//5k=; b=dOw65wL1I3pJFA5OkCVW55giVL jJOalIrBc4j5r5LTdtvyxA1zUhkCTVINrUqDH91ldAoL5//nxZU6VM6LJDAHN+y+04ahad3r6/7Yt DEQIDRkPkYN+kmbw6X2G+ZSVBc39WtgYe+rCMFFt6P9w8Inp3lDn8SSU1hIFnrcn+RwKzOlIUQMNP mN69RIlgKuKQzEI6IkWrsjn2oYkIsOcLAQeMo46wLMFqi0XRJFNiVgkPqEib7Nhgr8OGCQTJXqsJG l6xc1q3tNol6mXgirY7wtWqmBT69VNPXFz108aP/W+EQpl+jM1nykC/2BzDh9FJ1OHjmAoU6xeY31 lC0TRIqw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rDK1i-00DxGw-2a; Wed, 13 Dec 2023 07:51:30 +0000 Date: Tue, 12 Dec 2023 23:51:30 -0800 From: Luis Chamberlain To: Joel Granados , Dan Carpenter , Julia Lawall , Kees Cook Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , "Gustavo A. R. Silva" , Iurii Zaikin , Greg Kroah-Hartman , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables Message-ID: References: <20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net> <20231207104357.kndqvzkhxqkwkkjo@localhost> <20231208095926.aavsjrtqbb5rygmb@localhost> <8509a36b-ac23-4fcd-b797-f8915662d5e1@t-8ch.de> <20231212090930.y4omk62wenxgo5by@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231212090930.y4omk62wenxgo5by@localhost> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2023 at 10:09:30AM +0100, Joel Granados wrote: > My idea was to do something similar to your originl RFC, where you have > an temporary proc_handler something like proc_hdlr_const (we would need > to work on the name) and move each subsystem to the new handler while > the others stay with the non-const one. At the end, the old proc_handler > function name would disapear and would be completely replaced by the new > proc_hdlr_const. >=20 > This is of course extra work and might not be worth it if you don't get > negative feedback related to tree-wide changes. Therefore I stick to my > previous suggestion. Send the big tree-wide patches and only explore > this option if someone screams. I think we can do better, can't we just increase confidence in that we don't *need* muttable ctl_cables with something like smatch or coccinelle so that we can just make them const? Seems like a noble endeavor for us to generalize. Then we just breeze through by first fixing those that *are* using mutable tables by having it just de-register and then re-register new tables if they need to be changed, and then a new series is sent once we fix all those muttable tables. Luis