From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org, Alex Vinarskis <alex.vinarskis@gmail.com>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags
Date: Wed, 13 Dec 2023 18:17:18 +0200 [thread overview]
Message-ID: <ZXnZDjnor8oQNo2g@smile.fi.intel.com> (raw)
In-Reply-To: <20231213161352.GQ111411@google.com>
On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote:
> On Mon, 11 Dec 2023, Andy Shevchenko wrote:
...
> > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp),
> > + 0, lpss->priv, 1, 15, 16, 15,
> > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
> > - lpss->priv, 1, 15, 16, 15, 0,
> > NULL);
>
> What an ugly interface. Intel-only too, right?
Nope, de facto way how custom clocks are being introduced.
See clk-provider.h for several similar APIs (that require an
additional, custom, flags to be supplied).
...
> Have you also fixed this in: drivers/acpi/acpi_lpss.c
Already pending in Rafael's tree, yes.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-13 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 11:14 Andy Shevchenko
2023-12-13 16:13 ` Lee Jones
2023-12-13 16:17 ` Andy Shevchenko [this message]
2023-12-13 16:18 ` Lee Jones
2023-12-13 16:26 ` Andy Shevchenko
2023-12-13 17:46 ` Lee Jones
2023-12-13 18:47 ` Andy Shevchenko
2023-12-13 16:19 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXnZDjnor8oQNo2g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex.vinarskis@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®