From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5247C3C479; Fri, 15 Dec 2023 16:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aNffeOxo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702657700; x=1734193700; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=e0ojniOZ8WxwTGBWPkR76m9m2PjY31tBB/jsoZxQrFA=; b=aNffeOxoVv4gaVTv01R49kxGFgRJLYzgoMs1qIC/AE3lpUs8FUty71R2 VgMOfdNeeJaeptw5533me3HvPSeB/NCCw8eKV9yAhKCxhxjQCuUAdLsDl 5rDPZXIGj4rSDf4I9K2I4wy+quqIWoP3lpqt1NXqJ0nj5SCF0JahRpJMa 8JrENGRbaJ2sNKOReQ5I6S+VWyrsQXByC5N8FaTG4jepMjByzDrFJroYT 23U3484U+wIpCXcXSlyag9Y3KEMM4YCyhnw1T1idV6oPugUyJhFV82Nmn VNfH/BjrtHf4i4+2oa58/BpUiX9EIhXbRxQpjoS2jFy75NCVci7/NX9O9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="16849006" X-IronPort-AV: E=Sophos;i="6.04,279,1695711600"; d="scan'208";a="16849006" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2023 08:28:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="724503354" X-IronPort-AV: E=Sophos;i="6.04,279,1695711600"; d="scan'208";a="724503354" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2023 08:28:16 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rEB2r-00000006AUF-3aBR; Fri, 15 Dec 2023 18:28:13 +0200 Date: Fri, 15 Dec 2023 18:28:13 +0200 From: Andy Shevchenko To: Daniel Thompson Cc: Flavio Suligoi , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller Subject: Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties Message-ID: References: <20231214195158.1335727-1-andriy.shevchenko@linux.intel.com> <20231214195158.1335727-2-andriy.shevchenko@linux.intel.com> <20231215161102.GA662726@aspen.lan> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215161102.GA662726@aspen.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Dec 15, 2023 at 04:11:02PM +0000, Daniel Thompson wrote: > On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote: ... > > static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, > > Pretty minor... but I wonder if it should be renamed: > mp3309c_parse_fwnode(). I am fine with either. Lee, do you want this be incorporated? P.S> Flavio, thanks for testing! -- With Best Regards, Andy Shevchenko