From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F10F4EC for ; Thu, 28 Dec 2023 16:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FdY9aVsN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703781657; x=1735317657; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HpZoHXNF8wQeyDACOOvCNble18MrpAlcxrmoQ9Npfds=; b=FdY9aVsN/hn/1FvKYofVCp0rlQe0l6AbvWAaLv8vmt73PU7mR2MDUEB3 XF9vSrEDkTMEtNY1rQ5dDRrLNj6Y0QvZK7j1hMexVMmGc9p9m0nhmp2+u OhA34SfWJLQNizsZvX9ekq+TgFia24dczULly0GtO9XToYPLPHIcIIOlQ nEKj1b8tqqGRFYFu6OUmwvPoE2n/0IKLRvOFx2BiOJETmd7ytCYtKbsRm 37UBJigViDCljRv/iw+dwgafysmZPpDjvvJa0X5mnG1KpJFPAl4HaVHEi 2TbBGIOK/pMHjqMFRD7NGjoQPzj494jDA5CcMuyDfeLtsHAVSCaIWJzKh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="3856586" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="3856586" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:40:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="728353451" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="728353451" Received: from ceyeghel-mobl.amr.corp.intel.com (HELO intel.com) ([10.252.50.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:40:48 -0800 Date: Thu, 28 Dec 2023 17:40:44 +0100 From: Andi Shyti To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Subject: Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings Message-ID: References: <20231226195432.10891-1-rdunlap@infradead.org> <20231226195432.10891-3-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231226195432.10891-3-rdunlap@infradead.org> Hi Randy, [...] > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > @@ -105,61 +105,67 @@ struct intel_guc { > */ struct { } interrupts is missing here. > struct { > /** > - * @lock: protects everything in submission_state, > - * ce->guc_id.id, and ce->guc_id.ref when transitioning in and [...] > + * we start bypassing the schedule disable delay > */ > unsigned int sched_disable_gucid_threshold; > } submission_state; Here struct { } send_regs is missing But as for this patch: Reviewed-by: Andi Shyti Thanks, Andi > struct { > /** > - * @lock: Lock protecting the below fields and the engine stats. > + * @timestamp.lock: Lock protecting the below fields and [...]