From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] virtiofs: Improve error handling in virtio_fs_get_tree()
Date: Fri, 29 Dec 2023 08:51:22 +0000 [thread overview]
Message-ID: <ZY6Iir/idOZBiREy@casper.infradead.org> (raw)
In-Reply-To: <5745d81c-3c06-4871-9785-12a469870934@web.de>
On Fri, Dec 29, 2023 at 09:38:47AM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 29 Dec 2023 09:15:07 +0100
>
> The kfree() function was called in two cases by
> the virtio_fs_get_tree() function during error handling
> even if the passed variable contained a null pointer.
So what? kfree(NULL) is perfectly acceptable. Are you trying to
optimise an error path?
next prev parent reply other threads:[~2023-12-29 8:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 8:34 [PATCH 0/2] virtiofs: Adjustments for two function implementations Markus Elfring
2023-12-29 8:36 ` [PATCH 1/2] virtiofs: Improve three size determinations Markus Elfring
2024-01-02 20:41 ` Vivek Goyal
2023-12-29 8:38 ` [PATCH 2/2] virtiofs: Improve error handling in virtio_fs_get_tree() Markus Elfring
2023-12-29 8:51 ` Matthew Wilcox [this message]
2023-12-29 9:10 ` Markus Elfring
2023-12-29 14:21 ` Matthew Wilcox
2024-01-02 9:35 ` [2/2] " Markus Elfring
2024-01-02 10:17 ` Matthew Wilcox
2024-01-02 10:47 ` Markus Elfring
2024-01-02 16:28 ` Matthew Wilcox
2024-01-02 16:50 ` Markus Elfring
2024-01-02 20:21 ` [PATCH 2/2] " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY6Iir/idOZBiREy@casper.infradead.org \
--to=willy@infradead.org \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®