From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBE4125AD for ; Fri, 29 Dec 2023 15:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="udNjXux4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MMUixECVcqZI6/mrGqfR1zbER3vh+C3mM3cXKwGEL8s=; b=udNjXux4MUMTrSoC+YQQIhhvXc LrhlUHntT/e8YWgJ7h0BN5WXGP4LttWNJ3PgRTV6XR5hqI2MzN1/Y5XxrstdxNFtPJNleTAp+WAcn E3OIuoO6CXGseHGk+UdvvvbwJz3I7CDFEnXIs6GG2kO+rqFK9h1immV7yx7KGVE4FdhhvFJ3XR/ZZ jxQnAEn/z4CgqaRnMFpr0/S/s3MfwS5aaUKQVTIkUA+9NCHHZsAAgiVeBe0iXW0+bECFRMq4R0hpE +eCrDVdryXV/KzeJhKYlf0Y5YJJLD8Uzzm2vSedJGBAZni74fM/6tOxxEGkIeudd+RD7x7tYTDWfA QNCDrwnQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rJEwb-006J3z-Qo; Fri, 29 Dec 2023 15:38:41 +0000 Date: Fri, 29 Dec 2023 15:38:41 +0000 From: Matthew Wilcox To: Malkoot Khan Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style Message-ID: References: <20231229153238.153627-1-engr.mkhan1990@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231229153238.153627-1-engr.mkhan1990@gmail.com> On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote: > Move the opening brace of a function definition 'cma_for_each_area' > to the next line which resolved the error What error? This seems like the _wrong_ coding style to me. > Signed-off-by: Malkoot Khan > --- > mm/cma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/cma.c b/mm/cma.c > index 2b2494fd6b59..01ccd26e8bc2 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages, > } > > int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > + > { > int i; > > -- > 2.34.1 > >