From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Zhang Yiqun <zhangyiqun@phytium.com.cn>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<kuba@kernel.org>, <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfrm: Use spin_lock_bh() in xfrm_input()
Date: Mon, 18 Dec 2023 12:19:08 +0100 [thread overview]
Message-ID: <ZYAqrDSp6QuKv5I0@gauss3.secunet.de> (raw)
In-Reply-To: <CANn89i+t9t5ca=r6ZKw7s-HrxzgJjCB6hmWLccKmmxg8H=HUUA@mail.gmail.com>
On Mon, Dec 18, 2023 at 12:07:50PM +0100, Eric Dumazet wrote:
> On Mon, Dec 18, 2023 at 9:43 AM Zhang Yiqun <zhangyiqun@phytium.com.cn> wrote:
> >
> > This patch is to change spin_lock() into spin_lock_bh(), which can
> > disable bottem half in calling. If we leave this as spin_lock(),
> > it may stuck in a deadlock, because the callback in bottem half in
> > crypto driver will also call xfrm_input() again.
> >
> > Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
>
> When was the bug added ?
> We need a FIxes: tag.
This looks more like a 'crypto driver' bug. xfrm_input() runs in
the RX path and therefore expects to run with BHs off.
next prev parent reply other threads:[~2023-12-18 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:42 Zhang Yiqun
2023-12-18 11:07 ` Eric Dumazet
2023-12-18 11:19 ` Steffen Klassert [this message]
2023-12-18 11:17 ` [EXT] " Suman Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYAqrDSp6QuKv5I0@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangyiqun@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®