From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] driver core: bus: constantify subsys_register() calls
Date: Tue, 19 Dec 2023 17:03:10 +0200 [thread overview]
Message-ID: <ZYGwrrNH2EbB_mOM@smile.fi.intel.com> (raw)
In-Reply-To: <2023121908-grove-genetics-f8af@gregkh>
On Tue, Dec 19, 2023 at 02:15:09PM +0100, Greg Kroah-Hartman wrote:
> The functions subsys_register() and subsys_virtual_register() should be
> taking a constant pointer to a struct bus_type, as they do not actually
> modify anything in it, so fix up the function definitions to do so
> properly.
>
> This also changes the pointer type in struct subsys_interface to be
> constant as well, as again, that's the proper signature of it.
And they don't return any pointers, so no room for a mistake, and
even less with this patch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-12-19 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 13:15 Greg Kroah-Hartman
2023-12-19 15:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYGwrrNH2EbB_mOM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®