From: Nick Desaulniers <ndesaulniers@google.com>
To: Tanzir Hasan <tanzirh@google.com>
Cc: "Jorge Lopez" <jorge.lopez2@hp.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Al Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] platform/x86: hp-bioscfg: Removed needless asm-generic
Date: Wed, 20 Dec 2023 11:24:49 -0800 [thread overview]
Message-ID: <ZYM_gZAdEnczZiBz@google.com> (raw)
In-Reply-To: <20231219-hp-password-v1-1-052fe7b6b7f1@google.com>
On Tue, Dec 19, 2023 at 10:10:52PM +0000, Tanzir Hasan wrote:
> asm-generic/posix-types.h is obtained through bioscfg.h so there is no
> need to include it.
I verified that by:
1. building with V=1
2. taking the compiler invocation and adding -H
. drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
.. ./include/linux/wmi.h
... ./include/linux/device.h
.... ./include/linux/dev_printk.h
..... ./include/linux/compiler.h
...... ./arch/x86/include/generated/asm/rwonce.h
....... ./include/asm-generic/rwonce.h
........ ./include/linux/kasan-checks.h
......... ./include/linux/types.h
.......... ./include/uapi/linux/types.h
........... ./arch/x86/include/generated/uapi/asm/types.h
............ ./arch/x86/include/asm/posix_types.h
............. ./arch/x86/include/uapi/asm/posix_types_64.h
.............. ./include/uapi/asm-generic/posix_types.h
> It is also an asm-generic file which should be
> avoided if possible.
Correct, though there is a linux/posix_types.h file.
biocfg.h hasn't seen any changes since introduction; perhaps some reference was
removed in follow up changes to passwdobj-attributes.c, but nothing stood out.
Regardless, this file builds just fine without either (asm/posix_types.h or
linux/posix_types.h), and asm-generic should not be used (as suggested by Al).
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Suggest-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> index 03d0188804ba..f7efe217a4bb 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> @@ -7,7 +7,6 @@
> */
>
> #include "bioscfg.h"
> -#include <asm-generic/posix_types.h>
>
> GET_INSTANCE_ID(password);
> /*
>
> ---
> base-commit: 3fb7c66ac51a87984e043d9f47b7a509e3f53906
> change-id: 20231219-hp-password-19068dc438b5
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>
next prev parent reply other threads:[~2023-12-20 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 22:10 Tanzir Hasan
2023-12-20 19:24 ` Nick Desaulniers [this message]
2023-12-21 13:04 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYM_gZAdEnczZiBz@google.com \
--to=ndesaulniers@google.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jorge.lopez2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tanzirh@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®