From: Andy Shevchenko <andy@kernel.org>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Nick Desaulniers <nnn@google.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
llvm@lists.linux.dev, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v6 1/2] kernel.h: removed REPEAT_BYTE from kernel.h
Date: Wed, 27 Dec 2023 18:53:48 +0200 [thread overview]
Message-ID: <ZYxWnC5KEIx0XO5q@smile.fi.intel.com> (raw)
In-Reply-To: <20231226-libstringheader-v6-1-80aa08c7652c@google.com>
On Tue, Dec 26, 2023 at 06:00:00PM +0000, Tanzir Hasan wrote:
> This patch creates wordpart.h and includes it in asm/word-at-a-time.h
> for all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h
> because of REPEAT_BYTE. Moving this to another header and including it
> where necessary allows us to not include the bloated kernel.h. Making
> this implicit dependency on REPEAT_BYTE explicit allows for later
> improvements in the lib/string.c inclusion list.
LGTM, and I hope this will not trigger CIs and other build checkers.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
...
> --- a/arch/powerpc/include/asm/word-at-a-time.h
> +++ b/arch/powerpc/include/asm/word-at-a-time.h
> @@ -4,8 +4,8 @@
> /*
> * Word-at-a-time interfaces for PowerPC.
> */
> -
You can preserve this blank line...
> -#include <linux/kernel.h>
> +#include <linux/bitops.h>
> +#include <linux/wordpart.h>
...here.
> #include <asm/asm-compat.h>
> #include <asm/extable.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-27 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 17:59 [PATCH v6 0/2] shrink lib/string.i via IWYU Tanzir Hasan
2023-12-26 18:00 ` [PATCH v6 1/2] kernel.h: removed REPEAT_BYTE from kernel.h Tanzir Hasan
2023-12-27 16:53 ` Andy Shevchenko [this message]
2023-12-26 18:00 ` [PATCH v6 2/2] lib/string: shrink lib/string.i via IWYU Tanzir Hasan
2023-12-26 18:34 ` Andy Shevchenko
2023-12-26 18:47 ` Tanzir Hasan
2024-02-01 17:52 ` [PATCH v6 0/2] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYxWnC5KEIx0XO5q@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®