From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Walker Chen" <walker.chen@starfivetech.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Huisong Li" <lihuisong@huawei.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Wei Xu" <xuwei5@hisilicon.com>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Hal Feng" <hal.feng@starfivetech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx
Date: Wed, 27 Dec 2023 19:40:40 +0200 [thread overview]
Message-ID: <ZYxhmDlShZG23u-Y@smile.fi.intel.com> (raw)
On Sat, Dec 23, 2023 at 01:06:04PM +0300, Nikita Shubin wrote:
> On Wed, 2023-12-13 at 20:37 +0200, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:
...
> > > + dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
> >
> > Hmm... Is this message anyhow useful?
>
> Can we keep it please ? It makes us happy when we see it in logs for
> historical reasons - it's been there since 2.4.
Maybe it's good to add in the comment area / cover letter why this is useful.
--
With Best Regards,
Andy Shevchenko
next reply other threads:[~2023-12-27 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 17:40 Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-12 8:20 [PATCH v6 00/40] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay
2023-12-13 18:37 ` Andy Shevchenko
2023-12-23 10:06 ` Nikita Shubin
2023-12-23 11:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYxhmDlShZG23u-Y@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=hal.feng@starfivetech.com \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=kernel@esmil.dk \
--cc=lihuisong@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=ulf.hansson@linaro.org \
--cc=walker.chen@starfivetech.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®