From: Keith Busch <kbusch@kernel.org>
To: William Butler <wab@google.com>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Inform controller of doorbell config before unquiescing IO queues
Date: Wed, 10 Jan 2024 11:40:28 -0700 [thread overview]
Message-ID: <ZZ7knJGSVx8hWvaW@kbusch-mbp> (raw)
In-Reply-To: <20240110182855.1833512-1-wab@google.com>
On Wed, Jan 10, 2024 at 06:28:55PM +0000, William Butler wrote:
> During resets, if queues are unquiesced first, then the host can submit
> IOs to the controller using shadow doorbell logic but the controller
> won't be aware. This can lead to necessary MMIO doorbells from being
> not issued, causing requests to be delayed and timed-out.
Good catch. I guess we wouldn't normally expect any requests to be in
queue at this point, but plenty of reasons it could happen.
Applied to nvme-6.8 with a slightly updated title to match the local
conventions.
prev parent reply other threads:[~2024-01-10 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 18:28 William Butler
2024-01-10 18:40 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ7knJGSVx8hWvaW@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wab@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®