From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] min_heap: Min heap optimizations
Date: Thu, 4 Jan 2024 04:08:45 +0800 [thread overview]
Message-ID: <ZZW+zcfFOa5YgK2j@visitorckw-System-Product-Name> (raw)
In-Reply-To: <CAP-5=fXwa-GSDJX3pO-LSz-D_X7qk2Ck1vtdddtV8ixzsO+5BA@mail.gmail.com>
On Wed, Jan 03, 2024 at 09:56:29AM -0800, Ian Rogers wrote:
> On Wed, Dec 20, 2023 at 12:32 AM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> >
> > Hello,
> >
> > The purpose of this patch series is to enhance the existing min heap
> > implementation. The optimization focuses on both the heap construction
> > process and the number of comparisons made during the heapify
> > operation.
> >
> > Kuan-Wei Chiu (2):
> > min_heap: Optimize number of calls to min_heapify()
> > min_heap: Optimize number of comparisons in min_heapify()
>
> Thanks Kuan-Wei,
>
> The patch series looks good to me. Given the extra conditions should
> there be some updates to:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/test_min_heap.c
> to ensure coverage?
>
Hi Ian,
Thank you for your review.
The current min_heap test is sufficient to cover all the code changes
introduced by this patch series, even when only tested with a known
set of values copied from the data.
Additionally, I'm unsure if the commit message title prefix I used is
correct. Perhaps I should use "lib:" instead of "min_heap:"?
Best regards,
Kuan-Wei Chiu
next prev parent reply other threads:[~2024-01-03 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 8:32 Kuan-Wei Chiu
2023-12-20 8:32 ` [PATCH 1/2] min_heap: Optimize number of calls to min_heapify() Kuan-Wei Chiu
2023-12-20 8:32 ` [PATCH 2/2] min_heap: Optimize number of comparisons in min_heapify() Kuan-Wei Chiu
2024-01-03 17:56 ` [PATCH 0/2] min_heap: Min heap optimizations Ian Rogers
2024-01-03 20:08 ` Kuan-Wei Chiu [this message]
2024-01-03 20:21 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZW+zcfFOa5YgK2j@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®