Re: [PATCH] android: removed asm-generic/errno-base.h

[Carlos Llamas <cmllamas@google.com>]

On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > will still build correctly. It is an asm-generic file which should be
> > avoided if possible.
> > 
> > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > ---
> >   drivers/android/binderfs.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > index 1224ab7aa070..d04ff6029480 100644
> > --- a/drivers/android/binderfs.c
> > +++ b/drivers/android/binderfs.c
> > @@ -29,7 +29,7 @@
> >   #include <linux/uaccess.h>
> >   #include <linux/user_namespace.h>
> >   #include <linux/xarray.h>
> > -#include <uapi/asm-generic/errno-base.h>
> > +#include <linux/errno.h>
> 
> linux/errno.h is already included a few lines above.
> 
> CJ
> 

Good catch! Then we should just drop the errno-base.h include.

--
Carlos Llamas