mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: void@manifault.com, multics69@gmail.com,
	linux-kernel@vger.kernel.org, sched-ext@meta.com
Subject: Re: [PATCHSET sched_ext/for-6.16] sched_ext: Cleanup "ops" usage in symbols
Date: Fri, 4 Apr 2025 08:53:47 -1000	[thread overview]
Message-ID: <Z_Aqu8cKVHa4SnMR@slm.duckdns.org> (raw)
In-Reply-To: <Z--NLGOGQe_9xULR@gpd3>

On Fri, Apr 04, 2025 at 09:41:32AM +0200, Andrea Righi wrote:
> Hi Tejun,
> 
> On Thu, Apr 03, 2025 at 12:49:42PM -1000, Tejun Heo wrote:
> > The tag "ops" is used for two different purposes. First, to indicate that
> > the entity is directly related to the operations such as flags carried in
> > sched_ext_ops. Second, to indicate that the entity applies to something
> > global such as enable or bypass states. The second usage is historical and
> > causes confusion rather than clarifying anything. For example,
> > scx_ops_enable_state enums are named SCX_OPS_* and thus conflict with
> > scx_ops_flags.
> 
> We should probably rename also SCX_OPS_TASK_ITER_BATCH, which is not
> related to sched_ext_ops as well.
> 
> Apart than that and the other comment about scx_error(), this looks like a
> good cleanup.
> 
> Acked-by: Andrea Righi <arighi@nvidia.com>

Applied 1-5 to sched_ext/for-6.16. Will address the suggestions in separate
patches.

Thanks.

-- 
tejun

  reply	other threads:[~2025-04-04 18:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 22:49 Tejun Heo
2025-04-03 22:49 ` [PATCH 1/5] sched_ext: Drop "ops" from scx_ops_enable_state and friends Tejun Heo
2025-04-03 22:49 ` [PATCH 2/5] sched_ext: Drop "ops" from scx_ops_helper, scx_ops_enable_mutex and __scx_ops_enabled Tejun Heo
2025-04-03 22:49 ` [PATCH 3/5] sched_ext: Drop "ops" from scx_ops_bypass(), scx_ops_breather() and friends Tejun Heo
2025-04-03 22:49 ` [PATCH 4/5] sched_ext: Drop "ops" from scx_ops_exit(), scx_ops_error() " Tejun Heo
2025-04-04  7:30   ` Andrea Righi
2025-04-04 19:10     ` Tejun Heo
2025-04-04 20:06       ` Andrea Righi
2025-04-03 22:49 ` [PATCH 5/5] sched_ext: Drop "ops" from scx_ops_{init|exit|enable|disable}[_task]() " Tejun Heo
2025-04-04  7:41 ` [PATCHSET sched_ext/for-6.16] sched_ext: Cleanup "ops" usage in symbols Andrea Righi
2025-04-04 18:53   ` Tejun Heo [this message]
2025-04-04 19:12   ` [PATCH 6/5] sched_ext: Drop "ops" from SCX_OPS_TASK_ITER_BATCH Tejun Heo
2025-04-04 20:08     ` Andrea Righi
2025-04-04 20:10     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_Aqu8cKVHa4SnMR@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=multics69@gmail.com \
    --cc=sched-ext@meta.com \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®