From: Herbert Xu <herbert@gondor.apana.org.au>
To: T Pratham <t-pratham@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Kamlesh Gurudasani <kamlesh@ti.com>,
Manorit Chawdhry <m-chawdhry@ti.com>
Subject: Re: [PATCH RFC 1/2] crypto: ti: Add support for SHA224/256/384/512 in DTHE V2 driver
Date: Sat, 5 Apr 2025 09:36:21 +0800 [thread overview]
Message-ID: <Z_CJFVjAtvhi5Rvy@gondor.apana.org.au> (raw)
In-Reply-To: <Z_CIUXS-YfiRJxi5@gondor.apana.org.au>
On Sat, Apr 05, 2025 at 09:33:05AM +0800, Herbert Xu wrote:
>
> This is not unique either. Even the software implementation has
> to deal with this.
>
> This needs to be dealt with in your update function. Simply buffer
> leftover data and only feed whole blocks to the hardware, until
> fina/finup is called.
But it's a bit silly to duplicate code dealing with this common
problem. Since I'm going through every driver for the export format,
I think I will change the calling convention so that non-whole blocks
are dealt with by the API.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-04-05 1:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 10:49 [PATCH RFC 0/2] Add support for hashing algorithms in TI DTHE V2 T Pratham
2025-02-18 10:49 ` [PATCH RFC 1/2] crypto: ti: Add support for SHA224/256/384/512 in DTHE V2 driver T Pratham
2025-02-19 18:36 ` Kamlesh Gurudasani
2025-03-02 8:09 ` Herbert Xu
2025-04-02 13:31 ` T Pratham
2025-04-02 13:54 ` Herbert Xu
2025-04-02 14:12 ` T Pratham
2025-04-02 14:16 ` Herbert Xu
2025-04-03 8:28 ` T Pratham
2025-04-03 8:35 ` Herbert Xu
2025-04-04 10:15 ` T Pratham
2025-04-04 10:23 ` Herbert Xu
2025-04-04 12:40 ` T Pratham
2025-04-05 1:33 ` Herbert Xu
2025-04-05 1:36 ` Herbert Xu [this message]
2025-02-18 10:49 ` [PATCH RFC 2/2] crypto: ti: Add support for MD5 in DTHE V2 Hashing Engine driver T Pratham
2025-02-19 18:47 ` Kamlesh Gurudasani
2025-04-02 13:50 ` Herbert Xu
2025-04-02 14:21 ` T Pratham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_CJFVjAtvhi5Rvy@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kamlesh@ti.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=praneeth@ti.com \
--cc=t-pratham@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®