mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	"Berg, Johannes" <johannes.berg@intel.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
	"Berg, Benjamin" <benjamin.berg@intel.com>,
	"Anjaneyulu, Pagadala Yesu" <pagadala.yesu.anjaneyulu@intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: mld: fix building with CONFIG_PM_SLEEP disabled
Date: Sun, 6 Apr 2025 15:54:26 +0200	[thread overview]
Message-ID: <Z_KHkknIxQWzXhry@wunner.de> (raw)
In-Reply-To: <MW5PR11MB58106D6BC6403845C330C7AAA3A22@MW5PR11MB5810.namprd11.prod.outlook.com>

On Sun, Mar 30, 2025 at 04:49:38AM +0000, Korenblit, Miriam Rachel wrote:
> > From: Arnd Bergmann <arnd@kernel.org>
> > Sent: Tuesday, 25 March 2025 10:44
> > 
> > The newly added driver causes multiple build problems when CONFIG_PM_SLEEP
> > is disabled:
[...]
> > --- a/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > @@ -501,7 +501,7 @@ int iwl_mld_mac80211_start(struct ieee80211_hw *hw)
> >  		iwl_mld_restart_cleanup(mld);
> >  	}
> > 
> > -	if (!in_d3 || ret) {
> > +	if (!in_d3) {
> 
> Then where do you handle the in_d3 && ret case?

That seems to be a valid objection, yet Arnd's patch is now
commit 44605365f935 in wireless.git:

https://git.kernel.org/wireless/wireless/c/44605365f935

I'm proposing this v2:

https://lore.kernel.org/r/f435bd9c8186176ffa12fd3650fac71cacdeebe1.1743946314.git.lukas@wunner.de/

If wireless.git/main is a rebasing branch, consider replacing the
above-linked commit with the new version.  If it is not a rebasing
branch, let me know and I'll send a patch reinstating only the ret
in the if-condition.

Thanks,

Lukas

      reply	other threads:[~2025-04-06 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  8:43 Arnd Bergmann
2025-03-30  4:49 ` Korenblit, Miriam Rachel
2025-04-06 13:54   ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_KHkknIxQWzXhry@wunner.de \
    --to=lukas@wunner.de \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=benjamin.berg@intel.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=pagadala.yesu.anjaneyulu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®