From: Herbert Xu <herbert@gondor.apana.org.au>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Erhard Furtner <erhard_f@mailbox.org>
Subject: Re: [PATCH] crypto/testmgr: Fix acomp_req leak
Date: Tue, 8 Apr 2025 12:22:17 +0800 [thread overview]
Message-ID: <Z_Skef-ZAYAzPfOF@gondor.apana.org.au> (raw)
In-Reply-To: <20250408041647.88489-1-lizhijian@fujitsu.com>
On Tue, Apr 08, 2025 at 12:16:47PM +0800, Li Zhijian wrote:
> The kmemleak reported that
> ...
> unreferenced object 0xffff888108d6c300 (size 256):
> comm "cryptomgr_test", pid 183, jiffies 4294700957
> hex dump (first 32 bytes):
> 00 c1 d6 08 81 88 ff ff 00 cb d6 08 81 88 ff ff ................
> 50 cd a7 81 ff ff ff ff b8 fb 93 02 00 c9 ff ff P...............
> backtrace (crc 29cca632):
> __kmalloc_noprof+0x2fa/0x430
> test_acomp+0x174/0x960
> alg_test_comp+0x6f/0x90
> alg_test.part.26+0x105/0x410
> cryptomgr_test+0x20/0x40
> kthread+0x10c/0x250
> ret_from_fork+0x30/0x40
> ret_from_fork_asm+0x1a/0x30
> unreferenced object 0xffff888108d6c100 (size 256):
> comm "cryptomgr_test", pid 183, jiffies 4294700972
> hex dump (first 32 bytes):
> 00 1d da 08 81 88 ff ff 00 c3 d6 08 81 88 ff ff ................
> 50 cd a7 81 ff ff ff ff b8 fb 93 02 00 c9 ff ff P...............
> backtrace (crc 3047d62b):
> __kmalloc_noprof+0x2fa/0x430
> test_acomp+0x174/0x960
> alg_test_comp+0x6f/0x90
> alg_test.part.26+0x105/0x410
> cryptomgr_test+0x20/0x40
> kthread+0x10c/0x250
> ret_from_fork+0x30/0x40
> ret_from_fork_asm+0x1a/0x30
>
> acomp_request will be chained to req[0], however,
> acomp_request_free(), it will not free the whole chain.
>
> Fix it by freeing them one by one.
>
> Fixes: 99585c2192cb ("crypto: testmgr - Add multibuffer acomp testing")
> Reported-by: Erhard Furtner <erhard_f@mailbox.org>
> Closes: https://lore.kernel.org/linux-crypto/20250408002741.089f1e9a@outsider.home/
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> crypto/testmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the patch but this will be removed by
https://patchwork.kernel.org/project/linux-crypto/patch/048b1e176dd3507ec31497ccf215630dc2b2ed04.1744018301.git.herbert@gondor.apana.org.au/
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-04-08 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 4:16 Li Zhijian
2025-04-08 4:22 ` Herbert Xu [this message]
2025-04-08 5:39 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_Skef-ZAYAzPfOF@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=erhard_f@mailbox.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhijian@fujitsu.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®