mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: tip-bot2 for Josh Poimboeuf <tip-bot2@linutronix.de>,
	linux-tip-commits@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [tip: objtool/urgent] objtool: Fix false-positive "ignoring unreachables" warning
Date: Thu, 10 Apr 2025 22:55:54 +0200	[thread overview]
Message-ID: <Z_gwWnvENF6DY6h-@gmail.com> (raw)
In-Reply-To: <jd2rsmxvbvawlwwaatx323pzh5on3tjt5cxx5m7icf3sgj6vao@kjmjgb252u3x>


* Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> On Thu, Apr 10, 2025 at 06:14:43AM +0000, tip-bot2 for Josh Poimboeuf wrote:
> > The following commit has been merged into the objtool/urgent branch of tip:
> > 
> > Commit-ID:     8af6f0fe9c4340ed97f0ba4f3f6cc7bb16558e87
> > Gitweb:        https://git.kernel.org/tip/8af6f0fe9c4340ed97f0ba4f3f6cc7bb16558e87
> > Author:        Josh Poimboeuf <jpoimboe@kernel.org>
> > AuthorDate:    Wed, 09 Apr 2025 15:49:36 -07:00
> > Committer:     Ingo Molnar <mingo@kernel.org>
> > CommitterDate: Thu, 10 Apr 2025 08:03:05 +02:00
> > 
> > objtool: Fix false-positive "ignoring unreachables" warning
> > 
> > There's no need to try to automatically disable unreachable warnings if
> > they've already been manually disabled due to CONFIG_KCOV quirks.
> > 
> > This avoids a spurious warning with a KCOV kernel:
> > 
> >   fs/smb/client/cifs_unicode.o: warning: objtool: cifsConvertToUTF16.part.0+0xce5: ignoring unreachables due to jump table quirk
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > Link: https://lore.kernel.org/r/5eb28eeb6a724b7d945a961cfdcf8d41e6edf3dc.1744238814.git.jpoimboe@kernel.org
> > 
> > Closes: https://lore.kernel.org/r/202504090910.QkvTAR36-lkp@intel.com/
> 
> Superfluous newline there.

Fixed. Not sure what happened there.

> Also, this probably could use a fixes tag:
> 
> Fixes: eeff7ac61526 ("objtool: Warn when disabling unreachable warnings")

Added that one too.

Thanks!

	Ingo

  reply	other threads:[~2025-04-10 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09 22:49 [PATCH] objtool: Fix false " Josh Poimboeuf
2025-04-10  6:14 ` [tip: objtool/urgent] objtool: Fix false-positive " tip-bot2 for Josh Poimboeuf
2025-04-10 19:13   ` Josh Poimboeuf
2025-04-10 20:55     ` Ingo Molnar [this message]
2025-04-10 21:04 ` tip-bot2 for Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_gwWnvENF6DY6h-@gmail.com \
    --to=mingo@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tip-bot2@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®