From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A8B26AD9; Fri, 11 Apr 2025 11:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744372187; cv=none; b=INWxdNKHlYhuuA/hADqCNxR7vM4Oq7S6+e3AK5cPEGkOyF6R7pszgZV1MBOiw1NNcyFpY2CgjqXsCb06Wux66FSwS4ZsJT5SBgk9ITte0SGzbbSt19D3U/p83vPDUwxpBWH0mtZ9n4re9eSZ9LDQNqESCkv/P9O8MjHMQSdyYOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744372187; c=relaxed/simple; bh=Y1jBqB8SPrhS4Y4w/rmv4NVxsWmmjHCT1zX7FJlSn8U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D5eXOEtgE1ArzHc2coAbM/BqLTpkaELyqMHiQ1LK6DNj7xpgaa3QzooC9cWp1fanz/fti3IIXZJe7wmHG5nWAA8NOarArXyzAow/dB7cm7UDU8wyZ2R02npgC9Lt6Aw7vgiyM+vGuF+d+2g95dwN4mrxFu6SPWEgsH3Pz0IZ36k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=igkt2VE8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="igkt2VE8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7E00C4CEE2; Fri, 11 Apr 2025 11:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744372186; bh=Y1jBqB8SPrhS4Y4w/rmv4NVxsWmmjHCT1zX7FJlSn8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=igkt2VE8p0udba4TvCkKsv0xiU0tUm3e5M/XGbSLrV7UD28g8nyd/6e7DKEwO3uVf 1W9Z/VWJtH7C0QwvrphmcMBlMMUBzzsI8McD/PqLgPl0bytGjyx42SbTr6UaIJFVQt GZba/dgqwKgfGTKYKPBPgVmcs7TylcG9zE8Z07tDC061yVazw8szAHVGUaEnD82hMl WTJ/jmNJ/TsuHp1lvKcryh6e2YVBaQXjLrRxmL0aCG7A282RDNYQCc22L66GOI+7i3 hn/dLsMYdhbolbmFC/lJpD+f6mzn1+LbXHIKehBxRXjrByQ0JQzRhfk7Hcr13ZMJ7K zh7nKFoWiPZ6g== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1u3CtK-000000000on-156V; Fri, 11 Apr 2025 13:49:51 +0200 Date: Fri, 11 Apr 2025 13:49:50 +0200 From: Johan Hovold To: Christopher Obbard Cc: Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rui Miguel Silva , Abel Vesa , devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl Message-ID: References: <20250402-wip-obbardc-qcom-t14s-oled-panel-v5-0-ff33f4d0020f@linaro.org> <20250402-wip-obbardc-qcom-t14s-oled-panel-v5-1-ff33f4d0020f@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250402-wip-obbardc-qcom-t14s-oled-panel-v5-1-ff33f4d0020f@linaro.org> On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote: > Add edp_hpd_active pinctrl to the X1E80100 device tree. Please squash this one with the patch adding the user. > Signed-off-by: Christopher Obbard > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 46b79fce92c90d969e3de48bc88e27915d1592bb..5b1b80c445404fd02e9f6e5dab207610b03ff9c5 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -6389,6 +6389,11 @@ data-pins { > bias-pull-up; > }; > }; > + > + edp_hpd_active: edp-hpd-active-state { Please keep the nodes sorted by name. > + pins = "gpio119"; > + function = "edp_hot"; There is no "edp_hot" function on x1e so I wonder how this has been tested. As I mentioned in a comment to an earlier revision this pin has been configured by the firmware as "edp0_hot". Since there is also an "edp1_hot" pin, this needs to be reflected in the node name and label. Pin configurations really do belong in board files, but unfortunately this was not followed for x1e. You should still include the bias configuration (somewhere). > + }; > }; > > stm@10002000 { Johan