mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Shivank Garg <shivankg@amd.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	syzbot+8bb6fd945af4e0ad9299@syzkaller.appspotmail.com
Subject: Re: [PATCH] jfs: implement migrate_folio for jfs_metapage_aops
Date: Sun, 13 Apr 2025 21:41:08 +0100	[thread overview]
Message-ID: <Z_whZHPR64FHq6ve@casper.infradead.org> (raw)
In-Reply-To: <20250413172356.561544-1-shivankg@amd.com>

On Sun, Apr 13, 2025 at 05:23:57PM +0000, Shivank Garg wrote:
> +++ b/fs/jfs/jfs_metapage.c
> @@ -570,6 +570,7 @@ const struct address_space_operations jfs_metapage_aops = {
>  	.release_folio	= metapage_release_folio,
>  	.invalidate_folio = metapage_invalidate_folio,
>  	.dirty_folio	= filemap_dirty_folio,
> +	.migrate_folio	= filemap_migrate_folio,
>  };

Ooh, damn, I think we're going to need more than this ;-(

static inline struct metapage *folio_to_mp(struct folio *folio, int offset)
{
        return folio->private;
}

struct metapage {
...
        void *data;             /* Data pointer */

So we're going to need something like buffer_migrate_folio(), but
specialised to jfs metadata.  And when we come up with it, that'll
be Fixes: 35474d52c605

  reply	other threads:[~2025-04-13 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-13 17:23 Shivank Garg
2025-04-13 20:41 ` Matthew Wilcox [this message]
2025-04-14  4:53   ` Shivank Garg
2025-04-14 13:10   ` Shivank Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_whZHPR64FHq6ve@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaggy@kernel.org \
    --cc=shivankg@amd.com \
    --cc=syzbot+8bb6fd945af4e0ad9299@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®