From: Christoph Hellwig <hch@infradead.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
steve.kang@unisoc.com
Subject: Re: [PATCH] block: introduce content activity based ioprio
Date: Tue, 23 Jan 2024 05:06:00 -0800 [thread overview]
Message-ID: <Za+5uEpmNWbT8tXt@infradead.org> (raw)
In-Reply-To: <20240123093352.3007660-1-zhaoyang.huang@unisoc.com>
On Tue, Jan 23, 2024 at 05:33:52PM +0800, zhaoyang.huang wrote:
> #define ALLOC_CACHE_MAX 256
> @@ -1069,12 +1070,21 @@ EXPORT_SYMBOL_GPL(bio_add_zone_append_page);
> void __bio_add_page(struct bio *bio, struct page *page,
> unsigned int len, unsigned int off)
> {
> + int class, level, hint, activity;
> +
> + class = IOPRIO_PRIO_CLASS(bio->bi_ioprio);
> + level = IOPRIO_PRIO_LEVEL(bio->bi_ioprio);
> + hint = IOPRIO_PRIO_HINT(bio->bi_ioprio);
> + activity = IOPRIO_PRIO_ACTIVITY(bio->bi_ioprio);
> +
> WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED));
> WARN_ON_ONCE(bio_full(bio, len));
>
> bvec_set_page(&bio->bi_io_vec[bio->bi_vcnt], page, len, off);
> bio->bi_iter.bi_size += len;
> bio->bi_vcnt++;
> + activity += (bio->bi_vcnt <= IOPRIO_NR_ACTIVITY && PageWorkingset(page)) ? 1 : 0;
The block layer must not look at page bits. I've fixed all this crap
with a lot of work and we're not going to re-add it for another qute
hack. The place to figure out any kind of I/O priority is the file
system (preferably using generic helpers).
next prev parent reply other threads:[~2024-01-23 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 9:33 zhaoyang.huang
2024-01-23 13:06 ` Christoph Hellwig [this message]
2024-01-24 7:53 ` Zhaoyang Huang
2024-01-23 15:13 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za+5uEpmNWbT8tXt@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=huangzhaoyang@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.kang@unisoc.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®