From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7091r8: Fix error code in ad7091r8_gpio_setup()
Date: Thu, 11 Jan 2024 23:00:22 -0300 [thread overview]
Message-ID: <ZaCdNl6S1IRjyWru@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <fd905ad0-6413-489c-9a3b-90c0cdb35ec9@moroto.mountain>
On 01/08, Dan Carpenter wrote:
> There is a copy and paste error so it accidentally returns ->convst_gpio
> instead of ->reset_gpio. Fix it.
>
> Fixes: 0b76ff46c463 ("iio: adc: Add support for AD7091R-8")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Oops, that also slipped through.
Thanks for the fix.
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> drivers/iio/adc/ad7091r8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c
> index 57700f124803..700564305057 100644
> --- a/drivers/iio/adc/ad7091r8.c
> +++ b/drivers/iio/adc/ad7091r8.c
> @@ -195,7 +195,7 @@ static int ad7091r8_gpio_setup(struct ad7091r_state *st)
> st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(st->reset_gpio))
> - return dev_err_probe(st->dev, PTR_ERR(st->convst_gpio),
> + return dev_err_probe(st->dev, PTR_ERR(st->reset_gpio),
> "Error on requesting reset GPIO\n");
>
> if (st->reset_gpio) {
> --
> 2.42.0
>
>
next prev parent reply other threads:[~2024-01-12 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 9:07 Dan Carpenter
2024-01-12 2:00 ` Marcelo Schmitt [this message]
2024-01-21 16:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaCdNl6S1IRjyWru@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®