From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43B163AA; Mon, 15 Jan 2024 07:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eC/acpCm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705305200; x=1736841200; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zHlir3XfdsSMz2r6HDC4X+LUzUxt8NpAEvDxhpvgZBw=; b=eC/acpCmGITJb4Lchw3vp1G9Cmu83HU1HW5sOk7s2B2efmJ8sN62aVGm t+XPw+wY4vBXcI9Re67Rz4ZRBkSR3gbiSBPCqUwZ6+rZ38N3a7V5kdWQG y+OcSdw2EbZSQpirvHAe1JNZchwwtYOfdsx/0nwVR0m/sZUTTLH2kuA8T qTbpj0qWwYaOtjmn9qpnoMmJon90+aE79/ypfw7eOXbQDdXdDuVAnBPa5 KPPSfpasjwTJ4Z4stQ6s3OfC1jR4AEQr/nhPJcvkZAXtOc+UAAUDS8f6p o+P1Rpeydx2qz74u4TNqmcPzRK6eszY59Vz3Klflom5jAaAFHZzxyUvYu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10953"; a="6650794" X-IronPort-AV: E=Sophos;i="6.04,196,1695711600"; d="scan'208";a="6650794" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2024 23:53:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10953"; a="733229991" X-IronPort-AV: E=Sophos;i="6.04,196,1695711600"; d="scan'208";a="733229991" Received: from kuha.fi.intel.com ([10.237.72.185]) by orsmga003.jf.intel.com with SMTP; 14 Jan 2024 23:53:14 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 15 Jan 2024 09:53:13 +0200 Date: Mon, 15 Jan 2024 09:53:13 +0200 From: Heikki Krogerus To: "Christian A. Ehrhardt" Cc: linux-usb@vger.kernel.org, Dell.Client.Kernel@dell.com, Greg Kroah-Hartman , Neil Armstrong , Hans de Goede , Jack Pham , Fabrice Gasnier , Samuel =?utf-8?B?xIxhdm9q?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] usb: ucsi: Add quirk infrastructure Message-ID: References: <20240107001701.130535-1-lk@c--e.de> <20240107001701.130535-3-lk@c--e.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240107001701.130535-3-lk@c--e.de> On Sun, Jan 07, 2024 at 01:16:59AM +0100, Christian A. Ehrhardt wrote: > Allow bus drivers to specify quirks for the UCSI core on > attach. Allow the user to override the quirks on the command > line. > > Signed-off-by: Christian A. Ehrhardt > --- > Documentation/admin-guide/kernel-parameters.txt | 5 +++++ > drivers/usb/typec/ucsi/ucsi.c | 12 +++++++++++- > drivers/usb/typec/ucsi/ucsi.h | 6 +++++- > drivers/usb/typec/ucsi/ucsi_acpi.c | 2 +- > drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- > drivers/usb/typec/ucsi/ucsi_glink.c | 2 +- > drivers/usb/typec/ucsi/ucsi_stm32g0.c | 2 +- > 7 files changed, 25 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 0a6a4b7f7a3b..fd8152dd4450 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6783,6 +6783,11 @@ > ,,,,,,, > See also Documentation/input/devices/joystick-parport.rst > > + typec_ucsi.quirks= [USB] > + A hex value specifying the quirks to enable for > + the USB Type-C connector system software interface > + driver. This overrides auto detected quirks. New module parameters are not going to be accepted. Please just fix the issue with Dell's first like I proposed, and then you can start thinking about the infra for the quirks. thanks, -- heikki