From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Dmitry Antipov <dmantipov@yandex.ru>,
Christian Brauner <brauner@kernel.org>,
zack.rusin@broadcom.com, mcgrof@kernel.org, pstanner@redhat.com,
nick.alcock@oracle.com, code@siddh.me, ddiss@suse.de
Subject: Re: [PATCH AUTOSEL 5.10 01/10] watch_queue: fix kcalloc() arguments order
Date: Tue, 16 Jan 2024 21:43:09 +0100 [thread overview]
Message-ID: <ZabqXRf4X7wUgeqL@duo.ucw.cz> (raw)
In-Reply-To: <20240115232818.210010-1-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
Hi!
> From: Dmitry Antipov <dmantipov@yandex.ru>
>
> [ Upstream commit 1bfc466b13cf6652ba227c282c27a30ffede69a5 ]
>
> When compiling with gcc version 14.0.0 20231220 (experimental)
> and W=1, I've noticed the following warning:
>
> kernel/watch_queue.c: In function 'watch_queue_set_size':
> kernel/watch_queue.c:273:32: warning: 'kcalloc' sizes specified with 'sizeof'
> in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
> 273 | pages = kcalloc(sizeof(struct page *), nr_pages, GFP_KERNEL);
> | ^~~~~~
>
> Since 'n' and 'size' arguments of 'kcalloc()' are multiplied to
> calculate the final size, their actual order doesn't affect the
> result and so this is not a bug. But it's still worth to fix it.
Not a bugfix, please drop.
BR,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2024-01-16 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 23:27 Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 02/10] powerpc/mm: Fix null-pointer dereference in pgtable_cache_add Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 03/10] drivers/perf: pmuv3: don't expose SW_INCR event in sysfs Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 04/10] powerpc: Fix build error due to is_valid_bugaddr() Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 05/10] powerpc/mm: Fix build failures due to arch_reserved_kernel_pages() Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 06/10] x86/boot: Ignore NMIs during very early boot Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 07/10] powerpc: pmd_move_must_withdraw() is only needed for CONFIG_TRANSPARENT_HUGEPAGE Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 08/10] powerpc/lib: Validate size for vector operations Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 09/10] x86/barrier: Do not serialize MSR accesses on AMD Sasha Levin
2024-01-16 20:44 ` Pavel Machek
2024-01-30 20:58 ` Sasha Levin
2024-01-15 23:27 ` [PATCH AUTOSEL 5.10 10/10] x86/mce: Mark fatal MCE's page as poison to avoid panic in the kdump kernel Sasha Levin
2024-01-16 20:43 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZabqXRf4X7wUgeqL@duo.ucw.cz \
--to=pavel@denx.de \
--cc=brauner@kernel.org \
--cc=code@siddh.me \
--cc=ddiss@suse.de \
--cc=dmantipov@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=pstanner@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®