mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: [BUG] workqueues and printk not playing nice since next-20240130
Date: Fri, 2 Feb 2024 06:56:28 -1000	[thread overview]
Message-ID: <Zb0evDquygkDI_8P@slm.duckdns.org> (raw)
In-Reply-To: <25fd8537-5a27-4b62-9bf9-1ee7ca59b5b8@paulmck-laptop>

Hello,

On Fri, Feb 02, 2024 at 08:35:51AM -0800, Paul E. McKenney wrote:
> Good point, and if this sort of thing happens frequently, perhaps there
> should be an easy way of doing this.  One crude hack that might come
> pretty close would be to redefine the barrier() macro to be smp_mb().
> 
> But as noted earlier, -ENOREPRODUCE on today's -next.  I will try the
> next several -next releases.  But if they all get -ENOREPRODUCE, I owe
> everyone on CC an apology for having sent this report out before trying
> next-20240202.  :-/

I think I saw that problem too but could reproduce it with or without the
workqueue changes, so I did the lazy thing "oh well, somebody is gonna fix
that" and just tested as-is. It's a bit worrying that ppl don't seem to
already know what the culprit is. Hmm... I can't reproduce it anymore
either.

So, there is some chance that this may really be a subtle breakage. If you
ever see it happening again, triggering sysrq-t and capturing the dmesg
output (network should still work fine, so these shouldn't be too difficult)
may help. sysrq-t has workqueue state dump at the end which should clearly
indicate if anything is stalled in workqueue.

That said, another data point. In my test setup, I use the earlyprintk boot
option which enables console output way before than workqueue becomes
operational, so having on console output at all is highly unlikely to be
indicative of workqueue problem. My memory is hazy but it seems like I can
no longer reproduce the problem on the same git commit. Maybe it was a
problem on the qemu side?

Thanks.

-- 
tejun

  reply	other threads:[~2024-02-02 16:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 13:04 Paul E. McKenney
2024-02-02 14:12 ` John Ogness
2024-02-02 15:58   ` Paul E. McKenney
2024-02-02 17:02     ` John Ogness
2024-02-02 17:35       ` Paul E. McKenney
2024-02-02 14:26 ` Jonas Oberhauser
2024-02-02 16:35   ` Paul E. McKenney
2024-02-02 16:56     ` Tejun Heo [this message]
2024-02-02 17:40       ` Paul E. McKenney
2024-02-05 13:07         ` Petr Mladek
2024-02-05 13:25           ` Sergey Senozhatsky
2024-02-05 17:45             ` Paul E. McKenney
2024-02-05 17:46               ` Tejun Heo
2024-02-05 19:41                 ` Paul E. McKenney
2024-02-05 20:30                   ` Tejun Heo
2024-02-05 21:17                     ` Paul E. McKenney
2024-02-02 14:35 ` Petr Mladek
2024-02-02 16:07   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zb0evDquygkDI_8P@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=jonas.oberhauser@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome