mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee@kernel.org>, <alsa-devel@alsa-project.org>,
	<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>
Subject: Re: [PATCH 6/6] spi: cs42l43: Tidy up header includes
Date: Wed, 24 Jan 2024 15:20:47 +0000	[thread overview]
Message-ID: <ZbEqz31G+WfTtsZ/@ediswmail9.ad.cirrus.com> (raw)
In-Reply-To: <8b8fcdbd-b1c8-4618-acf8-e31b6ab33be7@sirena.org.uk>

On Wed, Jan 24, 2024 at 03:16:25PM +0000, Mark Brown wrote:
> On Wed, Jan 24, 2024 at 03:12:22PM +0000, Charles Keepax wrote:
> > Including some missing headers.
> > 
> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > 
> > The changes to the MFD headers necessitate the inclusion of of.h here to
> > keep things building, hence my including this SPI change in the this MFD
> > series. The rest of the SPI fixups will be sent separately, as they are
> > also not dependent on this change.
> 
> If this is needed to keep things building then presumably it should be
> before or part of whatever change introduces the requirement, otherwise
> we have a bisection issue.  Anyway:
> 
> Acked-by: Mark Brown <broonie@kernel.org>

Yup it should will, I forgot to CC Andy too, so this is a good
excuse to resend :-)

Thanks,
Charles

  reply	other threads:[~2024-01-24 15:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 15:12 [PATCH 1/6] mfd: " Charles Keepax
2024-01-24 15:12 ` [PATCH 2/6] mfd: cs42l43: Use __u8 type rather than u8 for firmware interface Charles Keepax
2024-01-24 15:12 ` [PATCH 3/6] mfd: cs42l43: Add time postfixes on defines Charles Keepax
2024-01-24 15:12 ` [PATCH 4/6] mfd: cs42l43: Add some missing dev_err_probes Charles Keepax
2024-01-24 15:12 ` [PATCH 5/6] mfd: cs42l43: Handle error from devm_pm_runtime_enable Charles Keepax
2024-01-24 15:12 ` [PATCH 6/6] spi: cs42l43: Tidy up header includes Charles Keepax
2024-01-24 15:16   ` Mark Brown
2024-01-24 15:20     ` Charles Keepax [this message]
2024-01-24 15:20 ` [PATCH 1/6] mfd: " Charles Keepax
2024-01-24 20:31   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbEqz31G+WfTtsZ/@ediswmail9.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®