From: andy.shevchenko@gmail.com
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Wei Xu" <xuwei5@hisilicon.com>,
"Huisong Li" <lihuisong@huawei.com>,
"Walker Chen" <walker.chen@starfivetech.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Arnd Bergmann" <arnd@arndb.de>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 08/39] soc: Add SoC driver for Cirrus ep93xx
Date: Sun, 4 Feb 2024 18:52:52 +0200 [thread overview]
Message-ID: <Zb_A5H5kkxw1oiQv@surfacebook.localdomain> (raw)
In-Reply-To: <20240118-ep93xx-v7-8-d953846ae771@maquefel.me>
Thu, Jan 18, 2024 at 11:20:51AM +0300, Nikita Shubin kirjoitti:
> Add an SoC driver for the ep93xx. Currently there is only one thing
> not fitting into any other framework, and that is the swlock setting.
>
> Used for clock settings, pinctrl and restart.
...
> +static struct auxiliary_device *ep93xx_adev_alloc(struct device *parent, const char *name,
> + struct ep93xx_map_info *info)
> +{
> + struct ep93xx_regmap_adev *rdev;
> + struct auxiliary_device *adev;
> + int ret;
> +
> + rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
> + if (!rdev)
> + return ERR_PTR(-ENOMEM);
Use __free() ?
(You already included cleanup.h for other cases, why not using it here?)
> + rdev->map = info->map;
> + rdev->base = info->base;
> + rdev->lock = &info->lock;
> + rdev->write = ep93xx_regmap_write;
> + rdev->update_bits = ep93xx_regmap_update_bits;
> +
> + adev = &rdev->adev;
> + adev->name = name;
> + adev->dev.parent = parent;
> + adev->dev.release = ep93xx_adev_release;
> +
> + ret = auxiliary_device_init(adev);
> + if (ret) {
> + kfree(adev);
> + return ERR_PTR(ret);
> + }
> +
> + return adev;
> +}
...
> + model = (enum ep93xx_soc_model)(uintptr_t)of_device_get_match_data(dev);
I believe Rob wants to get rid of of_device.h or at least of this call (see his
patches to convert this API to use device_get_match_data() instead).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-04 16:52 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:20 [PATCH v7 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 01/39] ARM: ep93xx: Add terminator to gpiod_lookup_table Nikita Shubin via B4 Relay
2024-01-18 23:52 ` Linus Walleij
2024-02-05 9:42 ` Alexander Sverdlin
2024-02-05 10:02 ` Arnd Bergmann
2024-02-05 10:13 ` Alexander Sverdlin
2024-02-04 16:32 ` andy.shevchenko
2024-02-05 8:52 ` Uwe Kleine-König
2024-01-18 8:20 ` [PATCH v7 02/39] gpio: ep93xx: split device in multiple Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 03/39] ARM: ep93xx: add regmap aux_dev Nikita Shubin via B4 Relay
2024-03-06 8:06 ` Linus Walleij
2024-01-18 8:20 ` [PATCH v7 04/39] clk: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 05/39] pinctrl: add a Cirrus ep93xx SoC pin controller Nikita Shubin via B4 Relay
2024-02-04 16:56 ` andy.shevchenko
2024-01-18 8:20 ` [PATCH v7 06/39] power: reset: Add a driver for the ep93xx reset Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 07/39] dt-bindings: soc: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 08/39] soc: Add SoC driver for Cirrus ep93xx Nikita Shubin via B4 Relay
2024-02-04 16:52 ` andy.shevchenko [this message]
2024-02-13 9:33 ` Nikita Shubin
2024-02-13 10:45 ` Andy Shevchenko
2024-01-18 8:20 ` [PATCH v7 09/39] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 10/39] dma: cirrus: Convert to DT for " Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 11/39] dt-bindings: watchdog: Add Cirrus EP93x Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 12/39] watchdog: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 13/39] dt-bindings: pwm: Add " Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 14/39] pwm: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 15/39] dt-bindings: spi: Add " Nikita Shubin via B4 Relay
2024-01-18 8:20 ` [PATCH v7 16/39] spi: ep93xx: add DT support for " Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 17/39] dt-bindings: net: Add " Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 18/39] net: cirrus: add DT support for " Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 19/39] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 20/39] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2024-02-04 16:49 ` andy.shevchenko
2024-01-18 8:21 ` [PATCH v7 21/39] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 22/39] ata: pata_ep93xx: add device tree support Nikita Shubin via B4 Relay
2024-02-04 17:00 ` andy.shevchenko
2024-01-18 8:21 ` [PATCH v7 23/39] dt-bindings: input: Add Cirrus EP93xx keypad Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 24/39] input: keypad: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 25/39] wdt: ts72xx: add DT support for ts72xx Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 26/39] gpio: ep93xx: add DT support for gpio-ep93xx Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 27/39] ASoC: dt-bindings: ep93xx: Document DMA support Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 28/39] ASoC: dt-bindings: ep93xx: Document Audio Port support Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 29/39] ASoC: ep93xx: Drop legacy DMA support Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 30/39] ARM: dts: add Cirrus EP93XX SoC .dtsi Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 31/39] ARM: dts: ep93xx: add ts7250 board Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 32/39] ARM: dts: ep93xx: Add EDB9302 DT Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 33/39] ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 34/39] pwm: ep93xx: drop legacy pinctrl Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 35/39] ata: pata_ep93xx: remove legacy pinctrl use Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 36/39] ARM: ep93xx: delete all boardfiles Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 37/39] ARM: ep93xx: soc: drop defines Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 38/39] ASoC: cirrus: edb93xx: Delete driver Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 39/39] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2024-01-18 9:30 ` [PATCH v7 00/39] ep93xx device tree conversion Uwe Kleine-König
2024-01-18 9:36 ` Nikita Shubin
2024-02-04 17:03 ` andy.shevchenko
2024-02-13 9:48 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb_A5H5kkxw1oiQv@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=lihuisong@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=ulf.hansson@linaro.org \
--cc=walker.chen@starfivetech.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®