From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2942660876 for ; Tue, 30 Jan 2024 10:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706609172; cv=none; b=jnlHcIL6i4WwX+ybfU+zRZuFt5YFKgRY+NIm3JsxHZNbp1rjHWC4ZNur9te2XJYvntO8i2SOBR6rxcF8+BIib6fg1NVqaUwkbI6hnTlZ95mVgubCBGXOzl48AnPB1357tsbmOg4GqS3DZpHpdMVxC0zIbU8Khju7sqRJdjHMHpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706609172; c=relaxed/simple; bh=mN24du69dfpVsjxf9h64v6haXtXcEvje0y/RHCPRKdk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D0H/4v67rFlqc7hgrwu6P7TNy66AVqWO9K25Gp6po7lRD8OAG8E/eCK4VM9FqyIXesYEX/9eAYfoaqja5SkS/y9ByiC+Sq4HOKKj/NuCvZuDj3j8QQQUePp4shN0En5cbO42RsL0CmsMT6TICJrdejf+MfQtrm1br1La/BEnaQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=ptrBUDj8; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="ptrBUDj8" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-55f0b2c79cdso2650174a12.3 for ; Tue, 30 Jan 2024 02:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706609168; x=1707213968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=77QGicsthLBoZ1ghB2R2tu5urtPmZmFpryoMl9wbInE=; b=ptrBUDj8duyMJozmAfnvAWXkTNC88SJPBaRHc+sZbg55/F3dsPDKBQooBP3miuLiYv dEn0M24AxaWjlv6epqEwnAl8sDrKgL55KuPek08txeoQ2JxERoTMHsVWTGu9d/P2U9wP sQIkKHajF88x4JqLIOI7C2ThOuoFLrNIfilR646auxdXMYDJE4VCyrJP+3Zjox4SzYev 3edT7sGCpZEem8UNIn44THKXwKVhuGuEkkOaMSy6sDB38OlxzVPvEPZGPs58nCb9kQM3 FKKgrQI0ytciiq3jtM7CDAos/odFwbrZBPLDsERCMRAQaW6SSMMXBCPXmVWZd/+A9Exq nm2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706609168; x=1707213968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=77QGicsthLBoZ1ghB2R2tu5urtPmZmFpryoMl9wbInE=; b=ikMzpZRVbrtIhndlMJmF4Sw37Tcg1SM1kUB9Zt/g1lIoyYRcD6bDzqWAKCj9KLYYEy Ejbc/RnGQegVAZijrqnoRivI2Uqdh32dkBI6/kEsDAC4jbcuFNS+ckkoT6aMf/RmYjU7 ej63vhf5oJ3h7Tl3/SbuaKyr10UOG5c9Xp3qvSE0bSiu5dnbCKq/NYcv+yJXckppYftO RuraQaH9tkvvlHeD8WXqJ9O2tRnYRHnbaYh0cMNRNDGX7FTvExIXosqYiw2KHUABlgTH wGVU6dAfaBzJ9jV4AXN57GiqTsRFQWsx77olHF8Q81JCTOfUdwLVR0LLrXcTy1SKsUGy 5GWA== X-Gm-Message-State: AOJu0YwVkFTlld2QgXkU9ukq9z2wNLyxf680M+2A//Oz+bvWCYTVwAvO oP6kK1f0yZBpKTWwvHM++NFC55m8pduW6l1pYEByBztHel94FJ+nD2E9/tYjId8= X-Google-Smtp-Source: AGHT+IEFGJwTV8iQxLqYycNi0re0c/Uh0a05u4IOgDhPC5KHMClkENdc+BnOMwOQQuUgVXt12gmVJg== X-Received: by 2002:a05:6402:281:b0:55f:3975:209c with SMTP id l1-20020a056402028100b0055f3975209cmr899981edv.18.1706609168242; Tue, 30 Jan 2024 02:06:08 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id k11-20020a056402340b00b0055f11bd3564sm1523017edc.8.2024.01.30.02.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:06:07 -0800 (PST) Date: Tue, 30 Jan 2024 11:06:04 +0100 From: Jiri Pirko To: Kunwu Chan Cc: roopa@nvidia.com, razor@blackwall.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Message-ID: References: <20240130092536.73623-1-chentao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130092536.73623-1-chentao@kylinos.cn> Tue, Jan 30, 2024 at 10:25:36AM CET, chentao@kylinos.cn wrote: >commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation") >introduces a new macro. >Use the new KMEM_CACHE() macro instead of direct kmem_cache_create >to simplify the creation of SLAB caches. > >Signed-off-by: Kunwu Chan >--- > net/bridge/br_fdb.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c >index c622de5eccd0..c77591e63841 100644 >--- a/net/bridge/br_fdb.c >+++ b/net/bridge/br_fdb.c >@@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly; > > int __init br_fdb_init(void) > { >- br_fdb_cache = kmem_cache_create("bridge_fdb_cache", >- sizeof(struct net_bridge_fdb_entry), >- 0, >- SLAB_HWCACHE_ALIGN, NULL); >+ br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN); Same remark as to the previous patch, the name would change. > if (!br_fdb_cache) > return -ENOMEM; > >-- >2.39.2 > >