From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B55285FB8B; Thu, 1 Feb 2024 05:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706766050; cv=none; b=s4hDyENTtqYDuQm0rigAl7/p3kUyQCNOnP2LzlNLvXgS7DtHAguWQzVLLocfOfeYfYVwFZAViaXsfrgfMi9rpRZ0tmXzF1JfgTrA1XSBjigFJO/AdBMYGFW1jo+q138tLGRKqzxnXwsM/iMyFGkUgHD9bYfQ/Qe4n55LubGEgqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706766050; c=relaxed/simple; bh=UEUfiP9mMy88eoTLAvjGfWU3BPt9BNiZ4XiYnzinCUk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VxCoInb8Y4oYCh/7NxXG4ZFf4TSxrZolpZiuQYGjkQ+Tp/LLEGn6Xm8XpQfdZIi5RFo9v8j8oRwMbSKIP9yOlJHsPEUivo+RYPmYAtux7FoSYGiPQ4lwlHH/nny6mTwssmDYhXrQVAPvW5YcS7mJg9KbfkTH4Zh4hVZFhwqTkmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rVPoQ-008UOM-Al; Thu, 01 Feb 2024 13:40:35 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 01 Feb 2024 13:40:47 +0800 Date: Thu, 1 Feb 2024 13:40:47 +0800 From: Herbert Xu To: JiaJie Ho Cc: "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100 Message-ID: References: <20240116090135.75737-1-jiajie.ho@starfivetech.com> <20240116090135.75737-5-jiajie.ho@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 01, 2024 at 03:01:59AM +0000, JiaJie Ho wrote: > > I am using ifdef so unused codes wouldn't be compiled into the driver for unsupported variant. > Is the compiled driver size a concern for such cases? The compiler should be eliminating unused code for you. Is this not the case? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt