From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
fuyuanli <fuyuanli@didiglobal.com>
Subject: Re: [PATCH] kernel/hung_task.c: export sysctl_hung_task_timeout_secs
Date: Wed, 14 Feb 2024 21:26:34 -0800 [thread overview]
Message-ID: <Zc2giqMeZhxuDSU9@infradead.org> (raw)
In-Reply-To: <20240209070935.1529844-1-kent.overstreet@linux.dev>
On Fri, Feb 09, 2024 at 02:09:35AM -0500, Kent Overstreet wrote:
> needed for thread_with_file; also rare but not unheard of to need this
> in module code, when blocking on user input.
>
> one workaround used by some code is wait_event_interruptible() - but
> that can be buggy if the outer context isn't expecting unwinding.
I don't think just exporting the variable ad thus allowing write
access is a good idea. If we want to keep going down the route of
this hack we should add an accessor function that returns the value.
The cleaner solution would be a new task state that explicitly
marks code than can sleep forever without triggerring the hang
check. Although this might be a bit invaѕive and take a while.
next prev parent reply other threads:[~2024-02-15 5:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 7:09 Kent Overstreet
2024-02-09 22:13 ` Andrew Morton
2024-02-09 22:22 ` Kent Overstreet
2024-02-15 5:26 ` Christoph Hellwig [this message]
2024-02-15 18:55 ` Andrew Morton
2024-02-15 23:26 ` Kent Overstreet
2024-02-16 7:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc2giqMeZhxuDSU9@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fuyuanli@didiglobal.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®