From: Matthew Wilcox <willy@infradead.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Jens Axboe <axboe@kernel.dk>, Yu Zhao <yuzhao@google.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
steve.kang@unisoc.com
Subject: Re: [PATCHv8 1/1] block: introduce content activity based ioprio
Date: Mon, 5 Feb 2024 22:05:11 +0000 [thread overview]
Message-ID: <ZcFbl0zP2pK6vEmh@casper.infradead.org> (raw)
In-Reply-To: <20240205090552.40567-1-zhaoyang.huang@unisoc.com>
On Mon, Feb 05, 2024 at 05:05:52PM +0800, zhaoyang.huang wrote:
> +void bio_set_active_ioprio(struct bio *bio)
why does this still exist? i said no.
> +void bio_set_active_ioprio_page(struct bio *bio, struct page *page)
this function should not exist.
> +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
this is the only one which should. did you even look at the
implementation of PageWorkingset?
> +extern void bio_set_active_ioprio(struct bio *bio);
> +extern void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio);
> +extern void bio_set_active_ioprio_page(struct bio *bio, struct page *page);
do not mark function prototypes with extern.
> +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> + /*
> + * bi_cont_act record total activities of bi_io_vec->pages
> + */
> + u64 bi_cont_act;
> +#endif
what?
look, you just don't understand. i've spent too much time replying to
you trying to help you. i give up. everything to do with this idea is
NAKed. go away.
next prev parent reply other threads:[~2024-02-05 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 9:05 zhaoyang.huang
2024-02-05 9:09 ` Zhaoyang Huang
2024-02-05 22:05 ` Matthew Wilcox [this message]
2024-02-06 0:44 ` Zhaoyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcFbl0zP2pK6vEmh@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=huangzhaoyang@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.kang@unisoc.com \
--cc=yuzhao@google.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®