From: Tycho Andersen <tycho@tycho.pizza>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidfd: exit: kill the no longer used thread_group_exited()
Date: Tue, 6 Feb 2024 10:04:08 -0700 [thread overview]
Message-ID: <ZcJmiBxpaElivX2J@tycho.pizza> (raw)
In-Reply-To: <20240205174347.GA31461@redhat.com>
On Mon, Feb 05, 2024 at 06:43:47PM +0100, Oleg Nesterov wrote:
> It was used by pidfd_poll() but now it has no callers.
>
> If it finally finds a modular user we can revert this change, but note
> that the comment above this helper and the changelog in 38fd525a4c61
> ("exit: Factor thread_group_exited out of pidfd_poll") are not accurate,
> thread_group_exited() won't return true if all other threads have passed
> exit_notify() and are zombies, it returns true only when all other threads
> are completely gone. Not to mention that it can only work if the task
> identified by @pid is a thread-group leader.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Tycho Andersen <tandersen@netflix.com>
next prev parent reply other threads:[~2024-02-06 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 17:43 Oleg Nesterov
2024-02-06 13:03 ` Christian Brauner
2024-02-06 17:04 ` Tycho Andersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-05 14:13 [PATCH] pidfd: change do_notify_pidfd() to use __wake_up(poll_to_key(EPOLLIN)) Oleg Nesterov
2024-02-06 12:53 ` Christian Brauner
2024-02-06 17:03 ` Tycho Andersen
2024-02-07 8:45 ` [PATCH] pidfd: exit: kill the no longer used thread_group_exited() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcJmiBxpaElivX2J@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®