From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion
Date: Wed, 7 Feb 2024 10:07:27 +0100 [thread overview]
Message-ID: <ZcNIT-NxKSZ44NjZ@hovoldconsulting.com> (raw)
In-Reply-To: <20240105-topic-venus_reset-v2-3-c37eba13b5ce@linaro.org>
On Tue, Feb 06, 2024 at 07:43:36PM +0100, Konrad Dybcio wrote:
> Trying to toggle the resets in a rapid fashion can lead to the changes
> not actually arriving at the clock controller block when we expect them
> to. This was observed at least on SM8250.
>
> Read back the value after regmap_update_bits to ensure write completion.
>
> Fixes: db1029814f1f ("clk: qcom: reset: Ensure write completion on reset de/assertion")
This commit does not exist in mainline or linux-next it seems.
Johan
next prev parent reply other threads:[~2024-02-07 9:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:43 [PATCH v2 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 01/18] clk: qcom: reset: Increase max reset delay Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 02/18] clk: qcom: reset: Commonize the de/assert functions Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion Konrad Dybcio
2024-02-07 9:07 ` Johan Hovold [this message]
2024-02-07 11:52 ` Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 04/18] clk: qcom: gcc-sa8775p: Set delay for Venus CLK resets Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 05/18] clk: qcom: gcc-sc8180x: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 06/18] clk: qcom: gcc-sc8280xp: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 07/18] clk: qcom: gcc-sm4450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 08/18] clk: qcom: gcc-sm7150: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 09/18] clk: qcom: gcc-sm8250: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 10/18] clk: qcom: gcc-sm8350: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 11/18] clk: qcom: gcc-sm8450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 12/18] clk: qcom: gcc-sm8550: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 13/18] clk: qcom: gcc-sm8650: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 14/18] clk: qcom: videocc-sm8150: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 15/18] clk: qcom: videocc-sm8250: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 16/18] clk: qcom: videocc-sm8350: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 17/18] clk: qcom: videocc-sm8450: " Konrad Dybcio
2024-02-06 18:43 ` [PATCH v2 18/18] clk: qcom: videocc-sm8550: " Konrad Dybcio
2024-02-07 4:46 ` [PATCH v2 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcNIT-NxKSZ44NjZ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®