From: Christoph Hellwig <hch@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
iommu@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik1@huawei-partners.com>,
Dexuan Cui <decui@microsoft.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH v4 5/5] iommu/dma: Force swiotlb_max_mapping_size on an untrusted device
Date: Tue, 27 Feb 2024 07:40:32 -0800 [thread overview]
Message-ID: <Zd4CcL3Nnvybw2xF@infradead.org> (raw)
In-Reply-To: <20240221113504.7161-6-will@kernel.org>
On Wed, Feb 21, 2024 at 11:35:04AM +0000, Will Deacon wrote:
> +static size_t iommu_dma_max_mapping_size(struct device *dev)
> +{
> + if (is_swiotlb_active(dev) && dev_is_untrusted(dev))
> + return swiotlb_max_mapping_size(dev);
Curious: do we really need both checks here? If swiotlb is active
for a device (for whatever reason), aren't we then always bound
by the max size? If not please add a comment explaining it.
next prev parent reply other threads:[~2024-02-27 15:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:34 [PATCH v4 0/5] Fix double allocation in swiotlb_alloc() Will Deacon
2024-02-21 11:35 ` [PATCH v4 1/5] swiotlb: Fix double-allocation of slots due to broken alignment handling Will Deacon
2024-02-21 23:35 ` Michael Kelley
2024-02-23 12:47 ` Will Deacon
2024-02-23 13:36 ` Petr Tesařík
2024-02-23 17:04 ` Michael Kelley
2024-02-27 15:38 ` Christoph Hellwig
2024-02-21 11:35 ` [PATCH v4 2/5] swiotlb: Enforce page alignment in swiotlb_alloc() Will Deacon
2024-02-21 23:36 ` Michael Kelley
2024-02-21 11:35 ` [PATCH v4 3/5] swiotlb: Honour dma_alloc_coherent() " Will Deacon
2024-02-21 23:36 ` Michael Kelley
2024-02-21 11:35 ` [PATCH v4 4/5] swiotlb: Fix alignment checks when both allocation and DMA masks are present Will Deacon
2024-02-21 23:37 ` Michael Kelley
2024-02-21 11:35 ` [PATCH v4 5/5] iommu/dma: Force swiotlb_max_mapping_size on an untrusted device Will Deacon
2024-02-21 23:39 ` Michael Kelley
2024-02-23 19:58 ` Nicolin Chen
2024-02-23 21:10 ` Michael Kelley
2024-02-25 21:17 ` Michael Kelley
2024-02-26 19:35 ` Robin Murphy
2024-02-26 21:11 ` Michael Kelley
2024-02-27 13:22 ` Robin Murphy
2024-02-27 14:30 ` Michael Kelley
2024-02-27 15:40 ` Christoph Hellwig [this message]
2024-02-27 15:53 ` Robin Murphy
2024-02-28 12:05 ` Will Deacon
2024-02-23 11:34 ` [PATCH v4 0/5] Fix double allocation in swiotlb_alloc() Nicolin Chen
2024-02-23 12:25 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd4CcL3Nnvybw2xF@infradead.org \
--to=hch@infradead.org \
--cc=decui@microsoft.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=nicolinc@nvidia.com \
--cc=petr.tesarik1@huawei-partners.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome