mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Yongqiang Liu <liuyongqiang13@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, yanaijie@huawei.com,
	zhangxiaoxu5@huawei.com, wangkefeng.wang@huawei.com,
	sunnanyong@huawei.com, linux@armlinux.org.uk, rppt@linux.ibm.com,
	linux-kernel@vger.kernel.org, keescook@chromium.org,
	arnd@arndb.de, m.szyprowski@samsung.com
Subject: Re: [PATCH] arm: flush: check if the folio is reserved for IMO addresses
Date: Thu, 22 Feb 2024 14:05:32 +0000	[thread overview]
Message-ID: <ZddUrO7i5KZn57FY@casper.infradead.org> (raw)
In-Reply-To: <20240222140147.1880357-1-liuyongqiang13@huawei.com>

On Thu, Feb 22, 2024 at 10:01:47PM +0800, Yongqiang Liu wrote:
> @@ -296,6 +297,9 @@ void __sync_icache_dcache(pte_t pteval)
>  		return;
>  
>  	folio = page_folio(pfn_to_page(pfn));
> +	if (test_bit(PG_reserved, &folio->flags))
> +		return;

Why are you using PG_foo directly instead of the helpers?

	if (folio_test_reserved(folio))

  reply	other threads:[~2024-02-22 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 14:01 Yongqiang Liu
2024-02-22 14:05 ` Matthew Wilcox [this message]
2024-02-23  1:57   ` Yongqiang Liu
2024-02-22 14:06 ` Kefeng Wang
2024-02-22 14:38   ` Russell King (Oracle)
2024-02-22 14:47     ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZddUrO7i5KZn57FY@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liuyongqiang13@huawei.com \
    --cc=m.szyprowski@samsung.com \
    --cc=rppt@linux.ibm.com \
    --cc=sunnanyong@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yanaijie@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®